From 1eb3f3b18dcea1cc46724751c2b758acb2ec2106 Mon Sep 17 00:00:00 2001 From: Henry Weller Date: Fri, 21 Jul 2017 17:38:31 +0100 Subject: [PATCH] surfaceFilmModels: 0.333 -> 1.0/3.0 and 0.666 -> 2.0/3.0 Resolves bug-report https://bugs.openfoam.org/view.php?id=2629 --- .../inclinedFilmNusseltHeightFvPatchScalarField.C | 6 +++--- .../inclinedFilmNusseltInletVelocityFvPatchVectorField.C | 6 +++--- .../kinematic/filmTurbulenceModel/laminar/laminar.C | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/regionModels/surfaceFilmModels/derivedFvPatchFields/inclinedFilmNusseltHeight/inclinedFilmNusseltHeightFvPatchScalarField.C b/src/regionModels/surfaceFilmModels/derivedFvPatchFields/inclinedFilmNusseltHeight/inclinedFilmNusseltHeightFvPatchScalarField.C index 39174d25c8..e34296a107 100644 --- a/src/regionModels/surfaceFilmModels/derivedFvPatchFields/inclinedFilmNusseltHeight/inclinedFilmNusseltHeightFvPatchScalarField.C +++ b/src/regionModels/surfaceFilmModels/derivedFvPatchFields/inclinedFilmNusseltHeight/inclinedFilmNusseltHeightFvPatchScalarField.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2012-2016 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2012-2017 OpenFOAM Foundation \\/ M anipulation | Copyright (C) 2016 OpenCFD Ltd. ------------------------------------------------------------------------------- License @@ -175,11 +175,11 @@ void Foam::inclinedFilmNusseltHeightFvPatchScalarField::updateCoeffs() const volScalarField& rho = film.rho(); const scalarField rhop(rho.boundaryField()[patchi].patchInternalField()); - const scalarField Re(max(G, scalar(0.0))/mup); + const scalarField Re(max(G, scalar(0))/mup); operator== ( - pow(3.0*sqr(mup/rhop)/(gTan + ROOTVSMALL), 0.333)*pow(Re, 0.333) + pow(3*sqr(mup/rhop)/(gTan + ROOTVSMALL), 1.0/3.0)*pow(Re, 1.0/3.0) ); fixedValueFvPatchScalarField::updateCoeffs(); diff --git a/src/regionModels/surfaceFilmModels/derivedFvPatchFields/inclinedFilmNusseltInletVelocity/inclinedFilmNusseltInletVelocityFvPatchVectorField.C b/src/regionModels/surfaceFilmModels/derivedFvPatchFields/inclinedFilmNusseltInletVelocity/inclinedFilmNusseltInletVelocityFvPatchVectorField.C index 22b08e7fa4..3bbc164e0a 100644 --- a/src/regionModels/surfaceFilmModels/derivedFvPatchFields/inclinedFilmNusseltInletVelocity/inclinedFilmNusseltInletVelocityFvPatchVectorField.C +++ b/src/regionModels/surfaceFilmModels/derivedFvPatchFields/inclinedFilmNusseltInletVelocity/inclinedFilmNusseltInletVelocityFvPatchVectorField.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2012-2016 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2012-2017 OpenFOAM Foundation \\/ M anipulation | Copyright (C) 2016 OpenCFD Ltd. ------------------------------------------------------------------------------- License @@ -177,9 +177,9 @@ void Foam::inclinedFilmNusseltInletVelocityFvPatchVectorField::updateCoeffs() const volScalarField& rho = film.rho(); const scalarField rhop(rho.boundaryField()[patchi].patchInternalField()); - const scalarField Re(max(G, scalar(0.0))/mup); + const scalarField Re(max(G, scalar(0))/mup); - operator==(n*pow(gTan*mup/(3.0*rhop), 0.333)*pow(Re, 0.666)); + operator==(n*pow(gTan*mup/(3*rhop), 1.0/3.0)*pow(Re, 2.0/3.0)); fixedValueFvPatchVectorField::updateCoeffs(); } diff --git a/src/regionModels/surfaceFilmModels/submodels/kinematic/filmTurbulenceModel/laminar/laminar.C b/src/regionModels/surfaceFilmModels/submodels/kinematic/filmTurbulenceModel/laminar/laminar.C index 44046a183a..3f2cbd6680 100644 --- a/src/regionModels/surfaceFilmModels/submodels/kinematic/filmTurbulenceModel/laminar/laminar.C +++ b/src/regionModels/surfaceFilmModels/submodels/kinematic/filmTurbulenceModel/laminar/laminar.C @@ -136,7 +136,7 @@ tmp laminar::Su(volVectorField& U) const // employ simple coeff-based model volScalarField Cs("Cs", Cf_*rhop*mag(Up - U)); - volScalarField Cw("Cw", mu/(0.3333*(delta + film.deltaSmall()))); + volScalarField Cw("Cw", mu/((1.0/3.0)*(delta + film.deltaSmall()))); Cw.min(5000.0); return