From 2ec0a1df051e64e1894f23a88c23d54c48c7582d Mon Sep 17 00:00:00 2001 From: Henry Date: Tue, 16 Dec 2014 08:38:18 +0000 Subject: [PATCH] Corrected calculation of multi-layer resistance Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1447 --- ...ntTemperatureCoupledBaffleMixedFvPatchScalarField.C | 8 +++----- ...ulentTemperatureRadCoupledMixedFvPatchScalarField.C | 10 +++------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/turbulenceModels/compressible/turbulenceModel/derivedFvPatchFields/turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.C b/src/turbulenceModels/compressible/turbulenceModel/derivedFvPatchFields/turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.C index ebca8d8ded..0ccf0ac820 100644 --- a/src/turbulenceModels/compressible/turbulenceModel/derivedFvPatchFields/turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.C +++ b/src/turbulenceModels/compressible/turbulenceModel/derivedFvPatchFields/turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.C @@ -117,14 +117,12 @@ turbulentTemperatureCoupledBaffleMixedFvPatchScalarField if (thicknessLayers_.size() > 0) { + // Calculate effective thermal resistance by harmonic averaging forAll (thicknessLayers_, iLayer) { - const scalar l = thicknessLayers_[iLayer]; - if (l > 0.0) - { - contactRes_ += kappaLayers_[iLayer]/l; - } + contactRes_ += thicknessLayers_[iLayer]/kappaLayers_[iLayer]; } + contactRes_ = 1.0/contactRes_; } } diff --git a/src/turbulenceModels/compressible/turbulenceModel/derivedFvPatchFields/turbulentTemperatureRadCoupledMixed/turbulentTemperatureRadCoupledMixedFvPatchScalarField.C b/src/turbulenceModels/compressible/turbulenceModel/derivedFvPatchFields/turbulentTemperatureRadCoupledMixed/turbulentTemperatureRadCoupledMixedFvPatchScalarField.C index 36c6106c73..1968da3888 100644 --- a/src/turbulenceModels/compressible/turbulenceModel/derivedFvPatchFields/turbulentTemperatureRadCoupledMixed/turbulentTemperatureRadCoupledMixedFvPatchScalarField.C +++ b/src/turbulenceModels/compressible/turbulenceModel/derivedFvPatchFields/turbulentTemperatureRadCoupledMixed/turbulentTemperatureRadCoupledMixedFvPatchScalarField.C @@ -123,16 +123,12 @@ turbulentTemperatureRadCoupledMixedFvPatchScalarField if (thicknessLayers_.size() > 0) { - // total thermal transmittance by harmonic averaging + // Calculate effective thermal resistance by harmonic averaging forAll (thicknessLayers_, iLayer) { - const scalar l = thicknessLayers_[iLayer]; - if (l > 0.0) - { - contactRes_ += l/kappaLayers_[iLayer]; // inverse sum - } + contactRes_ += thicknessLayers_[iLayer]/kappaLayers_[iLayer]; } - contactRes_ = 1.0/contactRes_; // new total inverse + contactRes_ = 1.0/contactRes_; } }