BUG: SPDP: PrecisionAdaptor copies input list. Fixes #1590.

This commit is contained in:
mattijs 2020-02-12 17:27:41 +00:00
parent 09db19c3f0
commit 4fea7b3bb4
4 changed files with 15 additions and 16 deletions

View File

@ -169,11 +169,14 @@ class PrecisionAdaptor
// Private Member Functions
//- Copy in field
void copyInput(const Container<InputType>& input)
void copyInput(const Container<InputType>& input, const bool copy)
{
Container<Type>* p = new Container<Type>(input.size());
this->reset(p);
std::copy(input.cbegin(), input.cend(), p->begin());
if (copy)
{
std::copy(input.cbegin(), input.cend(), p->begin());
}
}
@ -185,8 +188,8 @@ public:
// Constructors
//- Construct from Container<InputType>, copying on input as required
PrecisionAdaptor(Container<InputType>& input)
//- Construct from Container<InputType>, copying on input if required
PrecisionAdaptor(Container<InputType>& input, const bool copy = true)
:
tmpNrc<Container<Type>>(),
ref_(input)
@ -197,7 +200,7 @@ public:
}
else
{
this->copyInput(input);
this->copyInput(input, copy);
}
}

View File

@ -82,18 +82,14 @@ void Foam::primitiveMesh::makeCellCentresAndVols
{
typedef Vector<solveScalar> solveVector;
// Clear the fields for accumulation. Note1: we're doing this before
// any precision conversion since this might complain about illegal numbers.
// Note2: zero is a special value which is perfectly converted into zero
// in the new precision
cellCtrs_s = Zero;
cellVols_s = 0.0;
PrecisionAdaptor<solveVector, vector> tcellCtrs(cellCtrs_s);
PrecisionAdaptor<solveVector, vector> tcellCtrs(cellCtrs_s, false);
Field<solveVector>& cellCtrs = tcellCtrs.ref();
PrecisionAdaptor<solveScalar, scalar> tcellVols(cellVols_s);
PrecisionAdaptor<solveScalar, scalar> tcellVols(cellVols_s, false);
Field<solveScalar>& cellVols = tcellVols.ref();
cellCtrs = Zero;
cellVols = 0.0;
const labelList& own = faceOwner();
const labelList& nei = faceNeighbour();

View File

@ -229,7 +229,7 @@ Foam::label Foam::kahipDecomp::decomposeSerial
// Output: cell -> processor addressing
decomp.resize(numCells);
PrecisionAdaptor<int, label, List> decomp_param(decomp);
PrecisionAdaptor<int, label, List> decomp_param(decomp, false);
#if 0 // WIP: #ifdef KAFFPA_CPP_INTERFACE

View File

@ -196,7 +196,7 @@ Foam::label Foam::metisDecomp::decomposeSerial
// Output: cell -> processor addressing
decomp.resize(numCells);
PrecisionAdaptor<idx_t, label, List> decomp_param(decomp);
PrecisionAdaptor<idx_t, label, List> decomp_param(decomp, false);
// Output: number of cut edges
idx_t edgeCut = 0;