From 13ef974effc10b5e4fb1d116c87daf38f4e42458 Mon Sep 17 00:00:00 2001 From: sergio Date: Fri, 20 Apr 2012 12:16:50 +0100 Subject: [PATCH 1/5] ENH: Adding -overwrite option to mirrorMesh and update tutorial --- .../mesh/manipulation/mirrorMesh/mirrorMesh.C | 11 +++- .../pimpleFoam/elipsekkLOmega/Allclean | 1 - .../pimpleFoam/elipsekkLOmega/Allrun | 7 +-- .../elipsekkLOmega/constant/polyMesh/boundary | 52 ------------------- 4 files changed, 12 insertions(+), 59 deletions(-) delete mode 100644 tutorials/incompressible/pimpleFoam/elipsekkLOmega/constant/polyMesh/boundary diff --git a/applications/utilities/mesh/manipulation/mirrorMesh/mirrorMesh.C b/applications/utilities/mesh/manipulation/mirrorMesh/mirrorMesh.C index f050d82a79..e607080a66 100644 --- a/applications/utilities/mesh/manipulation/mirrorMesh/mirrorMesh.C +++ b/applications/utilities/mesh/manipulation/mirrorMesh/mirrorMesh.C @@ -37,15 +37,24 @@ using namespace Foam; int main(int argc, char *argv[]) { + +# include "addOverwriteOption.H" # include "setRootCase.H" # include "createTime.H" + const bool overwrite = args.optionFound("overwrite"); + + if (!overwrite) + { + runTime++; + } + mirrorFvMesh mesh ( IOobject ( mirrorFvMesh::defaultRegion, - runTime.timeName(), + runTime.constant(), runTime ) ); diff --git a/tutorials/incompressible/pimpleFoam/elipsekkLOmega/Allclean b/tutorials/incompressible/pimpleFoam/elipsekkLOmega/Allclean index 213da0de10..a25fd5e1c4 100755 --- a/tutorials/incompressible/pimpleFoam/elipsekkLOmega/Allclean +++ b/tutorials/incompressible/pimpleFoam/elipsekkLOmega/Allclean @@ -5,6 +5,5 @@ cd ${0%/*} || exit 1 # run from this directory . $WM_PROJECT_DIR/bin/tools/CleanFunctions cleanCase -rm -rf 0/polyMesh # ----------------------------------------------------------------- end-of-file diff --git a/tutorials/incompressible/pimpleFoam/elipsekkLOmega/Allrun b/tutorials/incompressible/pimpleFoam/elipsekkLOmega/Allrun index 612446c68e..fd85f49a95 100755 --- a/tutorials/incompressible/pimpleFoam/elipsekkLOmega/Allrun +++ b/tutorials/incompressible/pimpleFoam/elipsekkLOmega/Allrun @@ -10,17 +10,14 @@ application=`getApplication` runApplication blockMesh transformPoints -scale '(1.6666 1 1)' -#cp system/changeDictionaryDict.X system/changeDictionaryDict runApplication changeDictionary -instance system -dict system/changeDictionaryDict.X -runApplication mirrorMesh +runApplication mirrorMesh -overwrite rm log.mirrorMesh rm log.changeDictionary -#cp system/changeDictionaryDict.Y system/changeDictionaryDict runApplication changeDictionary -instance system -dict system/changeDictionaryDict.Y -runApplication mirrorMesh -cp -rf 0/polyMesh constant/ +runApplication mirrorMesh -overwrite runApplication topoSet runApplication createPatch -overwrite diff --git a/tutorials/incompressible/pimpleFoam/elipsekkLOmega/constant/polyMesh/boundary b/tutorials/incompressible/pimpleFoam/elipsekkLOmega/constant/polyMesh/boundary deleted file mode 100644 index 5370728b89..0000000000 --- a/tutorials/incompressible/pimpleFoam/elipsekkLOmega/constant/polyMesh/boundary +++ /dev/null @@ -1,52 +0,0 @@ -/*--------------------------------*- C++ -*----------------------------------*\ -| ========= | | -| \\ / F ield | OpenFOAM: The Open Source CFD Toolbox | -| \\ / O peration | Version: dev | -| \\ / A nd | Web: www.OpenFOAM.org | -| \\/ M anipulation | | -\*---------------------------------------------------------------------------*/ -FoamFile -{ - version 2.0; - format ascii; - class polyBoundaryMesh; - location "0/polyMesh"; - object boundary; -} -// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // - -5 -( - left - { - type symmetryPlane; - nFaces 320; - startFace 99210; - } - outlet - { - type patch; - nFaces 320; - startFace 99530; - } - up - { - type symmetryPlane; - nFaces 380; - startFace 99850; - } - hole - { - type wall; - nFaces 560; - startFace 100230; - } - frontAndBack - { - type empty; - nFaces 100000; - startFace 100790; - } -) - -// ************************************************************************* // From 980027bd607b2c01205d3019ad7e296d7627e4e8 Mon Sep 17 00:00:00 2001 From: sergio Date: Tue, 24 Apr 2012 10:43:44 +0100 Subject: [PATCH 2/5] BUG: Delay the call to solidThermo in Radiation BC constructor in case the solid region has not being constructed yet --- .../greyDiffusiveRadiationMixedFvPatchScalarField.C | 4 +++- .../system/bottomAir/changeDictionaryDict | 2 -- .../system/topAir/changeDictionaryDict | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/thermophysicalModels/radiationModels/derivedFvPatchFields/greyDiffusiveRadiation/greyDiffusiveRadiationMixedFvPatchScalarField.C b/src/thermophysicalModels/radiationModels/derivedFvPatchFields/greyDiffusiveRadiation/greyDiffusiveRadiationMixedFvPatchScalarField.C index 57acb81533..02637c203a 100644 --- a/src/thermophysicalModels/radiationModels/derivedFvPatchFields/greyDiffusiveRadiation/greyDiffusiveRadiationMixedFvPatchScalarField.C +++ b/src/thermophysicalModels/radiationModels/derivedFvPatchFields/greyDiffusiveRadiation/greyDiffusiveRadiationMixedFvPatchScalarField.C @@ -102,8 +102,10 @@ greyDiffusiveRadiationMixedFvPatchScalarField const scalarField& Tp = patch().lookupPatchField(TName_); + //NOTE: Assumes emissivity = 1 as the solidThermo might + // not be constructed yet refValue() = - 4.0*physicoChemical::sigma.value()*pow4(Tp)*emissivity()/pi; + 4.0*physicoChemical::sigma.value()*pow4(Tp)/pi; refGrad() = 0.0; valueFraction() = 1.0; diff --git a/tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/system/bottomAir/changeDictionaryDict b/tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/system/bottomAir/changeDictionaryDict index 7fc53289cc..f08a1ebff8 100644 --- a/tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/system/bottomAir/changeDictionaryDict +++ b/tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/system/bottomAir/changeDictionaryDict @@ -174,7 +174,6 @@ dictionaryReplacement type greyDiffusiveRadiation; T T; emissivityMode lookup; - Qro uniform 0; emissivity uniform 1.0; value uniform 0; } @@ -184,7 +183,6 @@ dictionaryReplacement type greyDiffusiveRadiation; T T; emissivityMode solidThermo; - Qro uniform 0; value uniform 0; } } diff --git a/tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/system/topAir/changeDictionaryDict b/tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/system/topAir/changeDictionaryDict index 6647732e8f..4c78380972 100644 --- a/tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/system/topAir/changeDictionaryDict +++ b/tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/system/topAir/changeDictionaryDict @@ -221,7 +221,6 @@ dictionaryReplacement type greyDiffusiveRadiation; T T; emissivityMode lookup; - Qro uniform 0; emissivity uniform 1.0; value uniform 0; } @@ -231,7 +230,6 @@ dictionaryReplacement type greyDiffusiveRadiation; T T; emissivityMode solidThermo; - Qro uniform 0; value uniform 0; } } From 01444d4b61d22ce63abe195f31af6dd15dcc306f Mon Sep 17 00:00:00 2001 From: mattijs Date: Tue, 24 Apr 2012 15:23:32 +0100 Subject: [PATCH 3/5] BUG: renumberMesh.C: update flip status for renumbered faces --- .../manipulation/renumberMesh/renumberMesh.C | 26 ++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/applications/utilities/mesh/manipulation/renumberMesh/renumberMesh.C b/applications/utilities/mesh/manipulation/renumberMesh/renumberMesh.C index 5f724095ca..395ee77cbe 100644 --- a/applications/utilities/mesh/manipulation/renumberMesh/renumberMesh.C +++ b/applications/utilities/mesh/manipulation/renumberMesh/renumberMesh.C @@ -1036,6 +1036,22 @@ int main(int argc, char *argv[]) ( UIndirectList