From fbeaad7e58ab30cf70f5b3a5a2095f46249fae24 Mon Sep 17 00:00:00 2001 From: Andrew Heather Date: Wed, 4 Jan 2017 15:59:49 +0000 Subject: [PATCH 1/7] BUG: test-mesh updated to test polyMesh constructor. Fixes #372 --- applications/test/mesh/Test-mesh.C | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/applications/test/mesh/Test-mesh.C b/applications/test/mesh/Test-mesh.C index d7d5895089..8aa69045ef 100644 --- a/applications/test/mesh/Test-mesh.C +++ b/applications/test/mesh/Test-mesh.C @@ -3,7 +3,7 @@ \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | \\ / A nd | Copyright (C) 2011-2016 OpenFOAM Foundation - \\/ M anipulation | + \\/ M anipulation | Copyright (C) 2017 OpenCFD Ltd. ------------------------------------------------------------------------------- License This file is part of OpenFOAM. @@ -40,7 +40,7 @@ int main(int argc, char *argv[]) #include "createTime.H" Info<< "Create mesh, no clear-out\n" << endl; - fvMesh mesh + polyMesh mesh ( IOobject ( @@ -51,12 +51,12 @@ int main(int argc, char *argv[]) ) ); - Info<< mesh.C() << endl; - Info<< mesh.V() << endl; - surfaceVectorField Cf = mesh.Cf(); - - Info<< Cf << endl; + + Info<< "Cell centres" << nl << mesh.cellCentres() << endl; + Info<< "Cell volumes" << nl << mesh.cellVolumes() << endl; + Info<< "Cell shapes" << nl << mesh.cellShapes() << endl; + Info<< "Cell face centres" << nl << mesh.faceCentres() << endl; // Test construct from cellShapes { @@ -83,7 +83,7 @@ int main(int argc, char *argv[]) word defaultBoundaryPatchName = "defaultFaces"; word defaultBoundaryPatchType = emptyPolyPatch::typeName; - fvMesh newMesh + polyMesh newMesh ( IOobject ( @@ -101,12 +101,10 @@ int main(int argc, char *argv[]) defaultBoundaryPatchType ); - Info<< newMesh.C() << endl; - Info<< newMesh.V() << endl; - - surfaceVectorField Cf = newMesh.Cf(); - - Info<< Cf << endl; + Info<< "New cell centres" << nl << newMesh.cellCentres() << endl; + Info<< "New cell volumes" << nl << newMesh.cellVolumes() << endl; + Info<< "New cell shapes" << nl << newMesh.cellShapes() << endl; + Info<< "New cell face centres" << nl << newMesh.faceCentres() << endl; } From 59dacd3145bed4000a4104de68300e1270bbc487 Mon Sep 17 00:00:00 2001 From: Andrew Heather Date: Wed, 4 Jan 2017 16:00:37 +0000 Subject: [PATCH 2/7] BUG: ISLList - did not close #ifdef with #endif --- src/OpenFOAM/containers/LinkedLists/user/ISLList.H | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/OpenFOAM/containers/LinkedLists/user/ISLList.H b/src/OpenFOAM/containers/LinkedLists/user/ISLList.H index 4d62f8d801..c685b6ffc0 100644 --- a/src/OpenFOAM/containers/LinkedLists/user/ISLList.H +++ b/src/OpenFOAM/containers/LinkedLists/user/ISLList.H @@ -43,4 +43,8 @@ namespace Foam using ISLList = ILList; } +// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // + +#endif + // ************************************************************************* // From 7655304b5e11c15a53b3a22deb2b1e590722a696 Mon Sep 17 00:00:00 2001 From: Andrew Heather Date: Wed, 4 Jan 2017 16:05:47 +0000 Subject: [PATCH 3/7] STYLE: Documentation updates - fixes #371 --- .../fixedNormalInletOutletVelocityFvPatchVectorField.H | 2 +- .../pressureInletOutletVelocityFvPatchVectorField.H | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/finiteVolume/fields/fvPatchFields/derived/fixedNormalInletOutletVelocity/fixedNormalInletOutletVelocityFvPatchVectorField.H b/src/finiteVolume/fields/fvPatchFields/derived/fixedNormalInletOutletVelocity/fixedNormalInletOutletVelocityFvPatchVectorField.H index 0c693a1d09..99d8d4c213 100644 --- a/src/finiteVolume/fields/fvPatchFields/derived/fixedNormalInletOutletVelocity/fixedNormalInletOutletVelocityFvPatchVectorField.H +++ b/src/finiteVolume/fields/fvPatchFields/derived/fixedNormalInletOutletVelocity/fixedNormalInletOutletVelocityFvPatchVectorField.H @@ -25,7 +25,7 @@ Class Foam::fixedNormalInletOutletVelocityFvPatchVectorField Group - grpInletletBoundaryConditions grpOutletBoundaryConditions + grpInletBoundaryConditions grpOutletBoundaryConditions Description This velocity inlet/outlet boundary condition combines a fixed normal diff --git a/src/finiteVolume/fields/fvPatchFields/derived/pressureInletOutletVelocity/pressureInletOutletVelocityFvPatchVectorField.H b/src/finiteVolume/fields/fvPatchFields/derived/pressureInletOutletVelocity/pressureInletOutletVelocityFvPatchVectorField.H index 6ca9107e9b..04516860eb 100644 --- a/src/finiteVolume/fields/fvPatchFields/derived/pressureInletOutletVelocity/pressureInletOutletVelocityFvPatchVectorField.H +++ b/src/finiteVolume/fields/fvPatchFields/derived/pressureInletOutletVelocity/pressureInletOutletVelocityFvPatchVectorField.H @@ -25,7 +25,7 @@ Class Foam::pressureInletOutletVelocityFvPatchVectorField Group - grpInletletBoundaryConditions grpOutletBoundaryConditions + grpInletBoundaryConditions grpOutletBoundaryConditions Description This velocity inlet/outlet boundary condition is applied to pressure @@ -49,7 +49,7 @@ Usage type pressureInletOutletVelocity; phi phi; tangentialVelocity uniform (0 0 0); - value uniform 0; + value uniform (0 0 0); } \endverbatim From 24610c7c0a00b7667fcb39d52e26d2142d5ede6e Mon Sep 17 00:00:00 2001 From: Andrew Heather Date: Wed, 4 Jan 2017 16:09:00 +0000 Subject: [PATCH 4/7] STYLE: Updated README text --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8197b85d56..3aa2503b54 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ OpenFOAM is free software: you can redistribute it and/or modify it under the te # OpenFOAM Trademark -OpenCFD Ltd grants use of the OpenFOAM trademark by Third Parties on a licence basis. ESI Group and the OpenFOAM Foundation Ltd are currently permitted to use the trademark. For information on trademark use, please refer to the [trademark policy guidelines](http://www.openfoam.com/legal/trademark-policy.php). +OpenCFD Ltd grants use of the OpenFOAM trademark by Third Parties on a licence basis. ESI Group and the OpenFOAM Foundation Ltd are currently permitted to use the Name and agreed Domain Name. For information on trademark use, please refer to the [trademark policy guidelines](http://www.openfoam.com/legal/trademark-policy.php). Please [contact OpenCFD](http://www.openfoam.com/contact) if you have any questions on the use of the OpenFOAM trademark. From 3eb706a38067f9564c33c86481156deed2017da2 Mon Sep 17 00:00:00 2001 From: Andrew Heather Date: Fri, 6 Jan 2017 10:55:46 +0000 Subject: [PATCH 5/7] BUG: turbulentDFSEMInlet BC - corrected singleProc usage for parallel runs. Fixes #374 --- .../turbulentDFSEMInletFvPatchVectorField.C | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/finiteVolume/fields/fvPatchFields/derived/turbulentDFSEMInlet/turbulentDFSEMInletFvPatchVectorField.C b/src/finiteVolume/fields/fvPatchFields/derived/turbulentDFSEMInlet/turbulentDFSEMInletFvPatchVectorField.C index 5a42c9e0d8..c68231649a 100644 --- a/src/finiteVolume/fields/fvPatchFields/derived/turbulentDFSEMInlet/turbulentDFSEMInletFvPatchVectorField.C +++ b/src/finiteVolume/fields/fvPatchFields/derived/turbulentDFSEMInlet/turbulentDFSEMInletFvPatchVectorField.C @@ -3,7 +3,7 @@ \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | \\ / A nd | Copyright (C) 2015 OpenFOAM Foundation - \\/ M anipulation | Copyright (C) 2016 OpenCFD Ltd. + \\/ M anipulation | Copyright (C) 2016-2017 OpenCFD Ltd. ------------------------------------------------------------------------------- License This file is part of OpenFOAM. @@ -311,6 +311,7 @@ void Foam::turbulentDFSEMInletFvPatchVectorField::initialisePatch() // Determine if all eddies spawned from a single processor singleProc_ = patch.size() == returnReduce(patch.size(), sumOp