Commit Graph

96 Commits

Author SHA1 Message Date
Mark Olesen
35afeb9b18 STYLE: remove superfluous uses of argList::validArgs.clear()
- a holdover from the old <root> <case> days
2010-05-03 08:38:39 +02:00
Mark Olesen
72f7d46f23 ENH: add operator[](const word&) as "find-by-name" to some classes
- affected: polyBoundary, fvBoundaryMesh, ZoneMesh, searchableSurfaces

  before:
      const label zoneI = mesh.cellZones().findZoneID(zoneName);
      const cellZone& cz = mesh.cellZones()[zoneI];
  after:
      const cellZone& cz = mesh.cellZones()[zoneName];
2010-04-29 10:12:35 +02:00
Mark Olesen
147fa2a75d STYLE: add notes to some (most) command-line options
- mapFields and splitMeshRegions need more clarification
2010-04-27 10:50:15 +02:00
Mark Olesen
4d2a297a67 BUG: syntax problems found by gcc-4.5.0
- "cpp -traditional-cpp" doesn't strip C++-style comments
  Probably need a workaround with sed -e 's@^ *//@@' if we
  wish to support C++-style comments in Make/{files,options}

- lduMatrixTests.C:121:1:
  error: ‘Foam::lduMatrix::solverPerformance::solverPerformance’ names
  the constructor, not the type

- edgeFaceCirculatorI.H:355:1:
  error: ‘Foam::edgeFaceCirculator::edgeFaceCirculator’ names the
  constructor, not the type

- patchPointEdgeCirculatorI.H:236:1:
  error: ‘Foam::patchPointEdgeCirculator::patchPointEdgeCirculator’
  names the constructor, not the type

- objToVTK.C:116:5:
  error: ‘Foam::argList::argList’ names the constructor, not the type

  same in surfaceClean.C, surfaceRefineRedGreen.C, surfaceSplitByPatch.C

- fireFoam/createFields.H:74:41:
  error: type/value mismatch at argument 1 in template parameter list
  for ‘template<class T> class Foam::autoPtr’
2010-04-22 09:00:31 +02:00
Mark Olesen
42807ddd7e STYLE: fix worst spacing violations for 'os <<' constructions
- accept some violations of the coding guidelines though
- perhaps adding a style exception would be simpler.
2010-04-13 17:45:49 +02:00
Mark Olesen
a50f01b079 STYLE: use forAllIter, forAllConstIter instead of long-hand version
STYLE: use 'forAll(' NOT 'forAll (', as per coding guide
2010-04-12 11:18:38 +02:00
Mark Olesen
d29c438657 STYLE: use url for FSF license instead of postal address, switch to GPL v3 2010-03-29 14:07:56 +02:00
Mark Olesen
a3fec987a8 CLEANUP: remove most references to (deprecated) .ftr file format
- use .obj files for debugging purposes instead.
2010-02-17 13:56:56 +01:00
Mark Olesen
689d4b2860 ENH: provide operator[] for accessing argList options.
- operator[] with label -> get args at index
- operator[] with word  -> get named option
2010-02-17 11:43:42 +01:00
Mark Olesen
d857d671ac STYLE: use new argList argRead() method and operator[] for cleaner code.
- deprecate argList::additionalArgs() method and remove uses of it
2010-02-16 17:57:49 +01:00
Mark Olesen
3613752115 ENH: add -tri (triangulate) option to foamToSurface, surfaceMeshConvert
STYLE: drop surface extraction from foamToStarMesh

- retain surfZone names when writing surfaces
- remove surface extraction/writing from meshWriter since it now
  duplicates what the meshedSurface class can do.
2010-02-10 11:49:53 +01:00
Mark Olesen
2f0692e002 Merge commit 'OpenCFD/master' into olesenm 2010-02-08 15:01:48 +01:00
graham
b98a01b28c ENH: surfaceInertia. Adding the calculation of the Q tensor, required
for six DoF motion bodies that are not principal axis aligned shapes
to start with.

Calculates the best match axes to give the most naturl transformation
from the Cartesian axes. The eigenvectors are returned in the order
relating to ascending magnitude of their eigenvalues - not necessarily
in a right handed triplet.
2010-02-04 19:51:31 +00:00
graham
1a9e6bcfad Revert "Removing large test .obj files from surfaceInertia utility directory."
This reverts commit edfba8be92.
2010-02-03 18:36:30 +00:00
Mark Olesen
8426ca1a8c Merge commit 'OpenCFD/master' into olesenm 2010-02-03 17:40:37 +01:00
graham
9f23282e0d STYLE: surfaceInertia. Adding space to option description. 2010-02-02 19:12:58 +00:00
Mark Olesen
ba69655de3 Merge commit 'OpenCFD/master' into olesenm 2010-01-26 09:06:52 +01:00
graham
edfba8be92 Removing large test .obj files from surfaceInertia utility directory. 2010-01-25 18:42:24 +00:00
Mark Olesen
a694f6e374 Replace a few uses of triSurface with the more general meshedSurface. 2010-01-15 17:27:03 +01:00
Mark Olesen
0d49e4711c Begin code refactoring of third-party file formats. 2010-01-15 14:35:50 +01:00
andy
25bf6b6ce8 Minor code style corrections 2009-12-22 10:06:37 +00:00
graham
aa847562ce Reimplementing the uniform density solid inertia calculation from:
http://www.geometrictools.com/LibPhysics/RigidBody/RigidBody.html

in surfaceInertia utility.  Allows calculation of shell or solid
properties of a triSurface, with optionally specified volumetric or
surface density.  Default behaviour is to calculate inertia around
centre of mass, with option to specify reference point.

Various test surfaces supplied and tested against analytical results.
2009-12-18 18:14:32 +00:00
Mark Olesen
d016db1bc6 Enhance edgeMesh to support more formats.
Read only support:

  .bdf, .nas - NASTRAN format. Handles both CBEAM and CROD as lines.
  CROD is what Hypermesh happens to output.

Write only support:

  .vtk - VTK legacy format in ASCII

Read/write support:
  .eMesh - native format, which is simply a list of points, edges
      with an additional IOobject header that lets them be moved about
      easily to use as a featureEdgeMesh.

  .inp - STAR-CD inp/cel/vrt combination
       IOobject header)

  .obj - Alias waverfront format

Radically simplify surfaceFeatureConvert by using the new edgeMesh
functionality.
2009-12-11 16:29:55 +01:00
Mark Olesen
0fc464254a Fix minor bug in surfaceFeatureExtract.C 2009-12-09 13:50:31 +01:00
Mark Olesen
30eac79d55 argList gets addNote() static method
- output any notes in the usage
2009-12-09 10:58:32 +01:00
Mark Olesen
190bbd69de add corners() method to boundBox 2009-12-07 13:06:03 +01:00
Mark Olesen
37c4f2f375 remove empty 'Description' from various .C files 2009-12-04 14:11:33 +01:00
Mark Olesen
5e972c772f remove trailing space from some files 2009-12-04 13:39:35 +01:00
Mark Olesen
c091d856ae pedantic changes: 'forAll (' -> 'forAll(' in applications/
- to match coding guidelines
2009-12-03 14:12:08 +01:00
Mark Olesen
58b7e64185 Use argList::addOption, argList::addBoolOption (almost) everywhere
- ensure that the standard options (eg, from timeSelector) also have
  some usage information
2009-12-03 13:32:12 +01:00
Mark Olesen
00985638d8 remove fvCFD.H usage from remaining library source
- exception calcType.H since it'll most likely be used for building
  applications anyhow

- use quailified names in more of the lagrangian code

- killed some tab indents in various places.
2009-12-02 15:34:52 +01:00
Mark Olesen
c3457b5152 argList - specializations for optionRead<string> etc.
- new optionLookupOrDefault and additional form of optionReadIfPresent
  with a default value
2009-12-02 13:45:11 +01:00
Mark Olesen
909e6b27e4 Apply coding style recommendations:
- space between keyword and bracket in 'for(..)', 'if(..)', 'while(..)'
2009-11-30 08:55:03 +01:00
Mark Olesen
fa93ce8cd7 coding style adherence
- markup codingStyleGuide.org examples so they actually indent correctly

- use 'Info<<' as per codingStyleGuide instead of 'Info <<'
2009-11-27 15:39:14 +01:00
Mark Olesen
d17d015f88 Use new last() method for List-type classes
- use first() method in some places as well where it helps clarity

- there are a few remaining cases: git grep 'size()-1]'
2009-11-26 13:35:57 +01:00
mattijs
6ae8581d03 explicit constructor 2009-11-13 18:18:32 +00:00
henry
e9da288118 Reverted the Americanism "math" back to the original "mathematical" and reverted name of
the include file back to mathematicalConstants.H to make upgrading code slightly easier.
2009-10-10 22:58:58 +01:00
mattijs
791b5aaeaa replacing isType with isA to enable directMappedWall to work 2009-09-15 17:51:59 +01:00
andy
8dcea0f8cd using new constant definitions 2009-08-28 18:04:22 +01:00
mattijs
064892f3f8 surface patch handling improvements 2009-08-17 22:04:14 +01:00
mattijs
adf3e4b7e1 clever usage of #include 2009-08-17 17:05:38 +01:00
mattijs
d8f39a9361 improved error message 2009-08-11 12:58:29 +01:00
andy
930477f0f1 updating verion dev->1.6 2009-07-24 17:49:15 +01:00
henry
816f6b3488 Updated the headers. 2009-07-24 17:01:31 +01:00
mattijs
801f18b5ed added region option 2009-07-01 13:55:05 +01:00
mattijs
918a34dca4 surface redistribution 2009-06-02 17:47:51 +01:00
Mark Olesen
d1295da31f adjust solvers and utilities to use new argList methods
- also drop various unused time options from src/OpenFOAM/include
2009-05-19 20:21:50 +02:00
mattijs
371903eb4a Merge branch 'master' of /home/noisy3/OpenFOAM/OpenFOAM-dev 2009-04-23 16:22:31 +01:00
mattijs
7de5697a2d use PatchTools algorithms 2009-04-20 17:49:24 +01:00
Mark Olesen
6a3d9effa0 fixed typo in surface utils 2009-04-17 11:16:44 +02:00