Commit Graph

100 Commits

Author SHA1 Message Date
Henry Weller
736621b945 fvOptions: Reorganized and updated to simplify use in sub-models and maintenance
fvOptions are transferred to the database on construction using
fv::options::New which returns a reference.  The same function can be
use for construction and lookup so that fvOptions are now entirely
demand-driven.

The abstract base-classes for fvOptions now reside in the finiteVolume
library simplifying compilation and linkage.  The concrete
implementations of fvOptions are still in the single monolithic
fvOptions library but in the future this will be separated into smaller
libraries based on application area which may be linked at run-time in
the same manner as functionObjects.
2015-12-02 11:49:52 +00:00
Henry Weller
3dfe844d9a applications/solvers: Added call to validate the turbulence model after construction
See also commit 52d83407f3
2015-12-01 10:25:38 +00:00
Henry Weller
e2ef006b91 applications: Update ...ErrorIn -> ...ErrorInFunction
Avoids the clutter and maintenance effort associated with providing the
function signature string.
2015-11-10 17:53:31 +00:00
Henry Weller
8d21b380ef Renamed phiAlpha -P alphaPhi for consistency with Euler-Euler solvers 2015-09-11 17:52:43 +01:00
Henry Weller
4c21f24a8c Input of dimensionedScalars: update read-construction of dimensionedScalar in applications
so that the specification of the name and dimensions are optional in property dictionaries.

Update tutorials so that the name of the dimensionedScalar property is
no longer duplicated but optional dimensions are still provided and are
checked on read.
2015-07-20 22:52:53 +01:00
Henry Weller
91e04d69c1 Resolve various unimportant warning messages from Gcc, Clang and Icpc 2015-07-19 11:31:49 +01:00
Henry Weller
0fb6a01280 fluxRequired: Added setFluxRequired function to fvSchemes class
Added calls to setFluxRequired for p, p_rgh etc. in all solvers which
avoids the need to add fluxRequired entries in fvSchemes dictionaries.
2015-07-15 21:57:16 +01:00
Henry
28abb8cda5 Buoyant solvers: Add special handling for ghRef in the case g = (0 0 0) 2015-03-19 15:26:06 +00:00
Henry
e588d61879 Solvers based on p_rgh: Added support for optional hRef
Allows the specification of a reference height, for example the height
of the free-surface in a VoF simulation, which reduces the range of p_rgh.

hRef is a uniformDimensionedScalarField specified via the constant/hRef
file, equivalent to the way in which g is specified, so that it can be
looked-up from the database.  For example see the constant/hRef file in
the DTCHull LTSInterFoam and interDyMFoam cases.
2015-03-17 17:15:11 +00:00
Henry
4b4ca3a247 compressibleInterDyMFoam and interPhaseChangeDyMFoam: cache divU before time advancement to ensure the old-time meshPhi are used to make phi absolute
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1531
2015-02-16 21:42:09 +00:00
Henry
8628ef2fea Corrected capitalization of Doxygen documentation comments 2015-02-14 13:10:15 +00:00
Henry
5a2c5c8fdc Explicitly name derived fields to improve readability of diagnostic messages and avoid duplicate registration 2015-02-12 09:59:52 +00:00
Henry
91ffedbeb2 Solvers: Rationalized correctPhi 2015-02-11 13:22:24 +00:00
Henry
45461bfcfe solvers: rationalize the construction of the fvOptions 2015-02-10 18:33:45 +00:00
Henry
fe8c5ff636 Applications: use pimpleControl.dict() and simpleControl.dict() instead of looking-up the sub-dict 2015-02-09 22:15:26 +00:00
Henry
9a40fb787e multiphase solvers: print phase-name rather than alpha1/2 when printing max and min phase-fraction 2015-01-21 20:07:15 +00:00
Henry
2aec249647 Updated the whole of OpenFOAM to use the new templated TurbulenceModels library
The old separate incompressible and compressible libraries have been removed.

Most of the commonly used RANS and LES models have been upgraded to the
new framework but there are a few missing which will be added over the
next few days, in particular the realizable k-epsilon model.  Some of
the less common incompressible RANS models have been introduced into the
new library instantiated for incompressible flow only.  If they prove to
be generally useful they can be templated for compressible and
multiphase application.

The Spalart-Allmaras DDES and IDDES models have been thoroughly
debugged, removing serious errors concerning the use of S rather than
Omega.

The compressible instances of the models have been augmented by a simple
backward-compatible eddyDiffusivity model for thermal transport based on
alphat and alphaEff.  This will be replaced with a separate run-time
selectable thermal transport model framework in a few weeks.

For simplicity and ease of maintenance and further development the
turbulent transport and wall modeling is based on nut/nuEff rather than
mut/muEff for compressible models so that all forms of turbulence models
can use the same wall-functions and other BCs.

All turbulence model selection made in the constant/turbulenceProperties
dictionary with RAS and LES as sub-dictionaries rather than in separate
files which added huge complexity for multiphase.

All tutorials have been updated so study the changes and update your own
cases by comparison with similar cases provided.

Sorry for the inconvenience in the break in backward-compatibility but
this update to the turbulence modeling is an essential step in the
future of OpenFOAM to allow more models to be added and maintained for a
wider range of cases and physics.  Over the next weeks and months more
turbulence models will be added of single and multiphase flow, more
additional sub-models and further development and testing of existing
models.  I hope this brings benefits to all OpenFOAM users.

Henry G. Weller
2015-01-21 19:21:39 +00:00
Henry
844b283030 New version of wmake supporting out-of-tree object and dependency files 2014-12-14 21:42:18 +00:00
Henry
a8f4c2f25e interPhaseChangeFoam: Do not correct phi at start of run
During restart correct phi would need the dilatation from the previous time-step.
Alternative is to run potentialFoam on 0 fields to initialise phi.
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1299
2014-05-20 16:15:07 +01:00
Henry
9873774ee9 VoF solvers: rationalize the relationship between VoF solvers
Improve code reuse
Add multiphaseInterDyMFoam
Retire MRFinterFoam -> now handled by interFoam with fvOptions
Update tutorials
2014-04-29 14:16:41 +01:00
Henry
e6236340b5 Removed alphaOuterCorrectors option because the mass-flux should be updated for all PIMPLE iterations
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1225
2014-03-17 21:31:09 +00:00
Henry
65ce3979fa Updated header 2014-01-28 13:08:39 +00:00
Henry
70f27712ae interPhaseChangeDyMFoam: Corrected correctPhi to include the phase-change dilatation effect 2014-01-28 13:07:35 +00:00
Henry
267f5cf0f5 interDyMFoam, interPhaseChangeDyMFoam : Use 1/A from the previous time-step rather than 1 in the pcorr equation
This provides better convergence and consistency between p_rgh and pcorr
2013-12-17 14:59:13 +00:00
Henry
a8c917fd4b DyM solvers: correct Uf using phi after construction 2013-12-11 17:26:34 +00:00
Henry
63da8af946 interFoam: Added isotropic compression option 2013-11-29 16:55:18 +00:00
Henry
f5fd050293 VoF solvers: phase-fraction equation and move mesh motion into PIMPLE loop 2013-10-30 12:50:12 +00:00
Henry
b994d6a11f MULES: Added support for predictor-corrector formulation to interFoam and LTSInterFoam 2013-10-27 21:00:46 +00:00
Henry
ada61bfe2c Rationalise correctPhi in VoF solvers 2013-09-11 16:18:41 +01:00
Henry
08baa6eda6 fixedFluxPressure BC: the snGrad is now pushed into the BC from pEqn.H rather than being evaluated in the BC 2013-09-11 00:10:00 +01:00
Henry
51f085faa5 Rewrite of ddtPhiCorr - ddtCorr and density-weight HbyA on compressible solvers.
For DyM solvers phiAbs is replaced by Uf but this conversion is currently not complete
2013-09-09 12:41:20 +01:00
Henry
2780df8365 multiphase: Update phase-naming to use the new convention e.g. alpha.water 2013-08-13 23:21:46 +01:00
Henry
2c4c1320d9 interPhaseChangeFoam: Compensate for compressibility effects 2013-08-05 15:21:54 +01:00
Henry
d3fa77a93e interPhaseChangeDyMFoam: New dynamic-mesh version of interPhaseChangeFoam 2013-07-17 11:26:14 +01:00
Henry
f18c1c53b2 phaseChangeTwoPhaseMixtures: Correct docs for mDotP function 2013-05-11 11:56:57 +01:00
Henry
d13c9810e8 VoF Solvers: Relocate the correction, sub-cycling and compressions controls from PIMPLE to the alpha1 sub-dict
MULES: Add support for explicit correction
interPhaseChangeFoam: Add option for explicit MULES or as correction to an upwind solution
Deprecate implicit form of MULES
2013-05-03 15:46:29 +01:00
Henry
473cf07dde MULES: Split files to separate the explicit and implicit forms
IMULES: MULES for implicit solution
2013-05-01 15:32:36 +01:00
Henry
c205857f0b interPhaseChangeFoam: Improve consistency with current interFoam 2013-04-28 21:53:30 +01:00
Henry
2bacd81371 interPhaseChangeFoam: corrected handling of alpha1 for transport and updated for consistency with interFoam 2013-04-27 15:31:14 +01:00
Henry
d05e256dcd src/transportModels: split twoPhaseMixture from twoPhaseProperties as a separate library 2013-03-09 16:15:29 +00:00
Henry
fdf751763d Update Headers 2013-02-07 12:31:14 +00:00
Henry
d53245c833 Multiphase: Update all solvers to accommodate the split between twoPhaseMixture and incompressibleTwoPhaseMixture 2013-02-07 12:31:00 +00:00
Henry
1ae61659fa interPhaseChangeFoam: No need to check continuity error and the velocity divergence defines the compressibility effect 2013-02-03 22:01:22 +00:00
opencfd
391a703b90 COMP: various: indirect linkage problems on Ubuntu12.04 2012-12-10 17:08:42 +00:00
Henry
6138cf6d47 Update headers 2012-10-24 17:25:12 +01:00
Henry
766abbc075 multiphase solver: Update and rationalize the alphaEqnSubCycling.H 2012-10-24 17:25:00 +01:00
Henry
a114345eab Thermodynamics and sub-models: Removed "Sp" boundedness corrections on transport, replaced with "bounded Gauss" scheme 2012-09-21 14:34:42 +01:00
Henry
b94d46d0e7 multiphase and fireFoam: set phi based on the interpolated U before the pEqn construction for the p BCs 2012-08-02 15:29:08 +01:00
Henry
0488709387 multiphase: Correct phi BCs for p BCs 2012-07-31 22:36:06 +01:00
Henry
1464c4ff5c multiphase (VoF): Added support for general turbulence models
Required the addition of the divDevRhoR function to all incompressible turbulence models
2012-07-27 14:56:01 +01:00