songtianlun/openfoam
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
20,673 Commits 104 Branches 33 Tags 325 MiB
660f3e5492
Commit Graph

66 Commits

Author SHA1 Message Date
Mark Olesen
660f3e5492 ENH: cleanup autoPtr class (issue #639) 
Improve alignment of its behaviour with std::unique_ptr

  - element_type typedef
  - release() method - identical to ptr() method
  - get() method to get the pointer without checking and without releasing it.
  - operator*() for dereferencing

Method name changes

  - renamed rawPtr() to get()
  - renamed rawRef() to ref(), removed unused const version.

Removed methods/operators

  - assignment from a raw pointer was deleted (was rarely used).
    Can be convenient, but uncontrolled and potentially unsafe.
    Do allow assignment from a literal nullptr though, since this
    can never leak (and also corresponds to the unique_ptr API).

Additional methods

  - clone() method: forwards to the clone() method of the underlying
    data object with argument forwarding.

  - reset(autoPtr&&) as an alternative to operator=(autoPtr&&)

STYLE: avoid implicit conversion from autoPtr to object type in many places

- existing implementation has the following:

     operator const T&() const { return operator*(); }

  which means that the following code works:

       autoPtr<mapPolyMesh> map = ...;
       updateMesh(*map);    // OK: explicit dereferencing
       updateMesh(map());   // OK: explicit dereferencing
       updateMesh(map);     // OK: implicit dereferencing

  for clarity it may preferable to avoid the implicit dereferencing

- prefer operator* to operator() when deferenced a return value
  so it is clearer that a pointer is involve and not a function call
  etc    Eg,   return *meshPtr_;  vs.  return meshPtr_();
 2018-02-26 12:00:00 +01:00
Mark Olesen
345a2a42f1 ENH: simplify method names for reading argList options and arguments 
- use succincter method names that more closely resemble dictionary
  and HashTable method names. This improves method name consistency
  between classes and also requires less typing effort:

    args.found(optName)        vs.  args.optionFound(optName)
    args.readIfPresent(..)     vs.  args.optionReadIfPresent(..)
    ...
    args.opt<scalar>(optName)  vs.  args.optionRead<scalar>(optName)
    args.read<scalar>(index)   vs.  args.argRead<scalar>(index)

- the older method names forms have been retained for code compatibility,
  but are now deprecated
 2018-01-08 15:35:18 +01:00
Mark Olesen
416a3790ea STYLE: prefer autoPtr::reset() to autoPtr::set() 
- in most cases already checked valid() so don't need additional check
  for setting an existing pointer
 2017-11-22 19:11:11 +01:00
Andrew Heather
efb39a8790 ENH: (further) Doxygen documentation updates for module support 2016-06-27 20:34:19 +01:00
andy
fd9d801e2d GIT: Initial commit after latest foundation merge 2016-04-25 11:40:48 +01:00
Henry Weller
4bc77e6aff Sprucing up the tutorials folder and adding -dict to "collapseEdges" 
Patch provided by Bruno Santos
Resolves patch application request http://www.openfoam.org/mantisbt/view.php?id=2015
 2016-03-06 19:06:44 +00:00
Andrew Heather
f0c3e8d599 STYLE: Updated version to 'plus' 2015-12-22 23:14:17 +00:00
Andrew Heather
04752147c8 GIT: Resolved conflict on merge from upstream 2015-12-22 16:49:44 +00:00
Andrew Heather
0e01c44129 GIT: Resolved conflict 2015-12-09 16:19:28 +00:00
Andrew Heather
5c9dff6146 GIT: Resolved conflict 2015-12-09 16:19:28 +00:00
Andrew Heather
8837a89237 STYLE: Updated links from openfoam.org to openfoam.com 2015-12-09 15:03:05 +00:00
Henry Weller
e2ef006b91 applications: Update ...ErrorIn -> ...ErrorInFunction 
Avoids the clutter and maintenance effort associated with providing the
function signature string.
 2015-11-10 17:53:31 +00:00
Henry
8628ef2fea Corrected capitalization of Doxygen documentation comments 2015-02-14 13:10:15 +00:00
Henry
1edf292c00 Correct Doxygen multiline comments 2015-02-14 10:59:29 +00:00
Henry
c778346c96 Formatting: Rationalized the indentation of #include 2015-02-10 20:35:50 +00:00
OpenFOAM-admin
9fb26d59d3 GIT: Repo update 2014-12-11 08:35:10 +00:00
OpenFOAM-admin
fbb3ddf2c4 Updated for release 2.3.0 2014-02-17 10:21:46 +00:00
mattijs
97ad9eab4c ENH: collapseEdges: avoid double registration of indirectPatchFaces 2013-10-03 10:42:23 +01:00
laurence
615a74626e ENH: foamyHexMesh: Include baffle handling 2013-09-25 12:37:19 +01:00
laurence
b4a742fc89 ENH: collapseEdges: Points now get a priority. The higher the number, the more likely the 
collapse will be towards that point
 2013-09-18 15:31:58 +01:00
laurence
fb52acf4be ENH: Update collapesEdges to work with any supplied face zone 2013-05-31 09:42:09 +01:00
laurence
c4b8448d53 BUG: collapseDict: Give entry a valid value 2013-04-12 14:16:09 +01:00
laurence
72c3da08b2 Merge branch 'master' into feature/cvMesh 
Conflicts:
	applications/test/Matrix/Test-Matrix.C
	applications/utilities/mesh/generation/extrude2DMesh/extrude2DMesh/extrude2DMesh/extrude2DMesh.C
	applications/utilities/mesh/generation/extrude2DMesh/extrude2DMesh/extrude2DMesh/extrude2DMesh.H
	src/OpenFOAM/algorithms/indexedOctree/indexedOctree.C
	src/OpenFOAM/primitives/Tensor2D/Tensor2DI.H
 2013-04-05 16:09:24 +01:00
andy
b45a4486b1 STYLE: Updates to erroneous copyright dates - applications 2013-03-13 09:45:16 +00:00
andy
951c8436aa ENH: Applying Gijs' patch: Update header documentation for utilities 2013-02-21 10:54:34 +00:00
laurence
4256e0a770 ENH: edgeCollapser: Make mesh checking optional and set default values for dictionary 
Update biconic25-55Run35 tutorial with simplified collapseDict
 2013-01-21 14:39:16 +00:00
laurence
32d358e4c3 Merge branch 'master' of /home/dm4/OpenFOAM/OpenFOAM-dev 2013-01-20 15:25:30 +00:00
laurence
ff3654956a STYLE: Code cleanup and add some comments 2013-01-10 10:50:05 +00:00
laurence
c0a417355d Revert "COMP: cvMesh and cv2DMesh removed" 
This reverts commit e4c1409679.
 2013-01-08 10:48:45 +00:00
laurence
e4c1409679 COMP: cvMesh and cv2DMesh removed 2013-01-07 16:08:56 +00:00
laurence
d722378fc4 ENH: cvMesh: detect and remove indirect patch faces 
Find patch faces that do not result from point pairs and aggressively delete
 2013-01-04 14:33:23 +00:00
laurence
e81813a9c2 ENH: Add edgeCollapser utility and libraries. 
edgeCollapser collapses small edges and faces.
Works in parallel by using PointEdgeWave.
 2012-12-11 17:12:27 +00:00
mattijs
e781b335bf STYLE: checkMesh,collapseEdges: renamed -meshQuality argument for consistency 2012-05-30 09:30:44 +01:00
mattijs
abbbe31f41 ENH: collapseEdges: parallel operation of mergeEdges 2012-05-17 11:58:35 +01:00
mattijs
b1d2767282 ENH: collapseEdges: read meshQualityDict. parallel operation. 2012-05-16 11:16:46 +01:00
mattijs
41308b9696 ENH: collapseEdges: parallel operation 2012-05-16 10:16:18 +01:00
laurence
453a455c83 BUG: Correct line length 2012-05-02 17:23:45 +01:00
laurence
c0695e04fa ENH: collapseEdges: Use PointEdgeWave to propagate collapse information 2012-04-20 17:07:10 +01:00
laurence
df636c4082 ENH: collapseEdges: WIP to extend to work in parallel 2012-04-17 16:48:44 +01:00
Henry
5682987dc7 Updated headers 2012-04-17 16:49:03 +01:00
Henry
cd51a5eea3 Consistency: Changed exponent FORTRAN style 'E' to C style 'e' 2012-04-17 16:48:27 +01:00
Henry
c2dd153a14 Copyright transfered to the OpenFOAM Foundation 2011-08-14 12:17:30 +01:00
andy
eaef8d482b STYLE: Updated 1991 start copyright year to 2004 2011-01-14 16:08:00 +00:00
andy
099cc39e2e Revert "STYLE: 2011 copyright date." 
This reverts commit b18f6cc1ce.
 2011-01-05 18:24:29 +00:00
graham
b18f6cc1ce STYLE: 2011 copyright date. 2011-01-05 11:14:26 +00:00
Mark Olesen
d29c438657 STYLE: use url for FSF license instead of postal address, switch to GPL v3 2010-03-29 14:07:56 +02:00
Mark Olesen
d857d671ac STYLE: use new argList argRead() method and operator[] for cleaner code. 
- deprecate argList::additionalArgs() method and remove uses of it
 2010-02-16 17:57:49 +01:00
Mark Olesen
ee293cde8e ENH: add usage information for '-overwrite' option. 
- make centrally available via #include "addOverwriteOption.H"
 2010-02-16 11:44:27 +01:00
Mark Olesen
58b7e64185 Use argList::addOption, argList::addBoolOption (almost) everywhere 
- ensure that the standard options (eg, from timeSelector) also have
  some usage information
 2009-12-03 13:32:12 +01:00
Mark Olesen
fa93ce8cd7 coding style adherence 
- markup codingStyleGuide.org examples so they actually indent correctly

- use 'Info<<' as per codingStyleGuide instead of 'Info <<'
 2009-11-27 15:39:14 +01:00