Commit Graph

50 Commits

Author SHA1 Message Date
Henry Weller
99a10ecea6 Boundary conditions: Added extrapolatedCalculatedFvPatchField
To be used instead of zeroGradientFvPatchField for temporary fields for
which zero-gradient extrapolation is use to evaluate the boundary field
but avoiding fields derived from temporary field using field algebra
inheriting the zeroGradient boundary condition by the reuse of the
temporary field storage.

zeroGradientFvPatchField should not be used as the default patch field
for any temporary fields and should be avoided for non-temporary fields
except where it is clearly appropriate;
extrapolatedCalculatedFvPatchField and calculatedFvPatchField are
generally more suitable defaults depending on the manner in which the
boundary values are specified or evaluated.

The entire OpenFOAM-dev code-base has been updated following the above
recommendations.

Henry G. Weller
CFD Direct
2016-02-20 22:44:37 +00:00
Henry Weller
e2ef006b91 applications: Update ...ErrorIn -> ...ErrorInFunction
Avoids the clutter and maintenance effort associated with providing the
function signature string.
2015-11-10 17:53:31 +00:00
Henry Weller
584fed888d twoPhaseEulerFoam/interfacialModels/dragModels/WenYu: Corrected Re -> Re*alpha_g
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1794
2015-08-04 13:29:11 +01:00
Henry Weller
365f9b0006 dimensioned<Type>: Added constructor from name, dimensions and dictionary
to simplify construction of dimensionedScalar properties and avoid the
duplication of the name string in the constructor call.
2015-07-21 12:57:07 +01:00
Henry
61e52b2cb4 twoPhaseEulerFoam: Move the residualAlpha used for drag into the phaseModel
This is necessary to guarantee consistency between the residualAlpha
used for drag and buoyancy in a multi-phase system
2015-06-07 18:55:24 +01:00
Henry
fc6b44ee3c twoPhaseEulerFoam: Added experimental face-based momentum equation formulation
This formulation provides C-grid like pressure-flux staggering on an
unstructured mesh which is hugely beneficial for Euler-Euler multiphase
equations as it allows for all forces to be treated in a consistent
manner on the cell-faces which provides better balance, stability and
accuracy.  However, to achieve face-force consistency the momentum
transport terms must be interpolated to the faces reducing accuracy of
this part of the system but this is offset by the increase in accuracy
of the force-balance.

Currently it is not clear if this face-based momentum equation
formulation is preferable for all Euler-Euler simulations so I have
included it on a switch to allow evaluation and comparison with the
previous cell-based formulation.  To try the new algorithm simply switch
it on, e.g.:

PIMPLE
{
    nOuterCorrectors 3;
    nCorrectors      1;
    nNonOrthogonalCorrectors 0;
    faceMomentum     yes;
}

It is proving particularly good for bubbly flows, eliminating the
staggering patterns often seen in the air velocity field with the
previous algorithm, removing other spurious numerical artifacts in the
velocity fields and improving stability and allowing larger time-steps
For particle-gas flows the advantage is noticeable but not nearly as
pronounced as in the bubbly flow cases.

Please test the new algorithm on your cases and provide feedback.

Henry G. Weller
CFD Direct
2015-04-27 21:33:58 +01:00
Henry
0f0672563b twoPhaseEulerFoam: removed unnecessary fvc.H 2015-01-08 16:25:17 +00:00
Henry
aceb69149e Reformat references 2014-12-19 21:33:16 +00:00
Henry
fa562216ab Corrected for SP compilation 2014-12-19 17:03:30 +00:00
Henry
090768c0b3 Reformatted references 2014-12-19 11:55:16 +00:00
Henry
c84400b358 Added IshiiZuber drag model 2014-12-19 11:53:17 +00:00
william
5d11952429 BUG: twoPhaseEulerFoam: bug fixes and bounding improvements to interfacal models 2014-06-05 16:08:39 +01:00
william
c07e1e0486 ENH: twoPhaseEulerFoam: added new interfacial models 2014-03-31 16:59:07 +01:00
william
acb63f5141 BUG: twoPhaseEulerFoam: corrected the definintion of K in turbulence models and in the segregated drag model 2014-03-18 15:03:41 +00:00
william
e71b49311c STYLE: twoPhaseEulerFoam: updated interfacial model headers to reflect changes in the definition of K 2014-03-18 09:07:35 +00:00
william
37c75a8b18 BUG: twoPhaseEulerFoam: removed multiple of the continuous phase fraction from force and heat transfer models 2014-03-17 16:34:32 +00:00
Henry
078e4b6980 Removed noDrag and noHeatTransfer models 2014-03-03 11:08:30 +00:00
william
a96e531f5c BUG: twoPhaseEulerFoam: fixed typo in GidaspowSchillerNaumann drag and stability issues in fludised bed cases 2014-02-03 16:05:24 +00:00
william
05a34f3dfa ENH: twoPhaseEulerFoam: changed Cd function to CdRe and removed some residual constants 2014-02-03 12:51:59 +00:00
william
4e36e9ce1c BUG: twoPhaseEulerFoam: fixed multiple registering of blended drag and virtual mass models 2014-01-29 10:16:16 +00:00
william
87115af2d0 ENH: twoPhaseEulerFoam: Removed requirement that a model (most likely "none") had to be specified for all pairs 2014-01-23 16:37:16 +00:00
william
e4c45b821e STYLE: twoPhaseEulerFoam: changed coefficient names in segregated drag model 2014-01-23 11:05:55 +00:00
william
4735a5b023 STYLE: twoPhaseEulerFoam: Added header references and comments to new interfacial models 2014-01-23 10:09:55 +00:00
william
509529cab8 ENH: Added bubble library functionality to twoPhaseEulerFoam 2014-01-22 17:46:17 +00:00
Henry
e0dbbdfbb7 Updated headers 2013-08-15 10:30:50 +01:00
Henry
175f03f87d Removed twoPhaseEulerFoam and renamed compressibleTwoPhaseEulerFoam -> twoPhaseEulerFoam 2013-08-15 10:30:09 +01:00
Henry
c2041f9dba multiphase: completed phase renaming 2012-03-01 18:22:59 +00:00
Henry
2491f257b1 Corrected line lengths 2012-02-29 16:39:53 +00:00
Henry
0b1bcbb753 Remove non-ASCII characters 2012-01-19 16:27:23 +00:00
Henry
ae582a7a12 twoPhaseEulerFoam/interfacialModels/dragModels/WenYu: minor reorganisation 2011-09-09 16:51:10 +01:00
Henry
c2dd153a14 Copyright transfered to the OpenFOAM Foundation 2011-08-14 12:17:30 +01:00
Henry
729bdbb640 twoPhaseEulerFoam/interfacialModels/dragModels: Corrections for parallel operation 2011-07-05 17:02:21 +01:00
andy
eaef8d482b STYLE: Updated 1991 start copyright year to 2004 2011-01-14 16:08:00 +00:00
andy
099cc39e2e Revert "STYLE: 2011 copyright date."
This reverts commit b18f6cc1ce.
2011-01-05 18:24:29 +00:00
graham
b18f6cc1ce STYLE: 2011 copyright date. 2011-01-05 11:14:26 +00:00
Mark Olesen
078c427594 COMP: avoid ambiguous construct from tmp - solvers/ multiphase 2010-12-21 09:53:19 +01:00
Henry
89ee9b3e0f Merged all multiphase developments in OpenFOAM-1.7.x 2010-09-29 22:22:48 +01:00
graham
012494fdb5 STYLE: Fixing code style requirements for all apps.
Exception: applyWallFunctionBoundaryConditions.C cannot split #include
directives.
2010-07-27 15:27:05 +01:00
Mark Olesen
03338b9ea9 STYLE: partial revert for 5cfa97624e 2010-04-23 10:23:08 +02:00
Mark Olesen
5cfa97624e STYLE: more consistent New methods, use unregistered IOobject where appropriate 2010-04-20 17:13:35 +02:00
Mark Olesen
937e0d23d0 STYLE: consistent naming of files containing the 'New' method
before:
    - 'new' prefixed to camel-cased class name: eg, someClass -> newSomeClass
    - 'New' prefixed to templated class name:   eg, TmplClass -> NewTmplClass
    - 'New' suffixed to class name:             eg, someClass -> someClassNew

after:
    - consistent 'New' suffixed to class name, no change of case
          eg, someClass -> someClassNew
          eg, TmplClass -> TmplClassNew
2010-04-13 18:47:47 +02:00
Mark Olesen
d29c438657 STYLE: use url for FSF license instead of postal address, switch to GPL v3 2010-03-29 14:07:56 +02:00
Mark Olesen
c091d856ae pedantic changes: 'forAll (' -> 'forAll(' in applications/
- to match coding guidelines
2009-12-03 14:12:08 +01:00
Mark Olesen
909e6b27e4 Apply coding style recommendations:
- space between keyword and bracket in 'for(..)', 'if(..)', 'while(..)'
2009-11-30 08:55:03 +01:00
Mark Olesen
fa93ce8cd7 coding style adherence
- markup codingStyleGuide.org examples so they actually indent correctly

- use 'Info<<' as per codingStyleGuide instead of 'Info <<'
2009-11-27 15:39:14 +01:00
henry
31c76da40f Changed the runtime-selection tables to output a sorted toc. 2009-08-06 18:01:28 +01:00
Mark Olesen
28b200bcd9 update copyrights for 2009 2008-12-31 19:01:56 +01:00
Mark Olesen
02cabc3cf2 updated Copyright (C) \d+-2008 OpenCFD Ltd. 2008-06-25 15:01:46 +02:00
henry
ad19741845 Added kineticTheoryModels namespace and put the viscosityModels in it to
avoid name-clashes with the standard viscosityModels.

The other kineticTheoryModels have yet to be put in the kineticTheoryModels
namespace.
2008-06-18 23:11:09 +01:00
OpenFOAM-admin
3170c7c0c9 Creation of OpenFOAM-dev repository 15/04/2008 2008-04-15 18:56:58 +01:00