From 0bca23ff77a80ef8c7037dfcacca619fd22c7e76 Mon Sep 17 00:00:00 2001 From: songtianlun Date: Sat, 26 Apr 2025 00:29:33 +0800 Subject: [PATCH] fix: correct state name presence check - Update condition to check for state presence instead of name - Ensure proper rendering of state badge in city and weather art views This change improves the logic for displaying the state badge by checking for the presence of the state object directly, which prevents potential errors when the state name is not set. It ensures that the badge is displayed correctly when a state is associated with a city or weather art. --- app/views/cities/show.html.erb | 2 +- app/views/weather_arts/show.html.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/cities/show.html.erb b/app/views/cities/show.html.erb index 537d899..25ae9c3 100644 --- a/app/views/cities/show.html.erb +++ b/app/views/cities/show.html.erb @@ -45,7 +45,7 @@ <%= link_to cities_path(country: @city.country, state: @city.state, region: @city.country.region), class: "badge badge-lg badge-secondary hover:badge-outline transition-all duration-200" do %> <%= @city.state.name %> <% end %> - <% elsif @city.state.name.present? %> + <% elsif @city.state.present? %>
<%= @city&.state&.name %>
diff --git a/app/views/weather_arts/show.html.erb b/app/views/weather_arts/show.html.erb index 6fa8dac..c3975c6 100644 --- a/app/views/weather_arts/show.html.erb +++ b/app/views/weather_arts/show.html.erb @@ -37,7 +37,7 @@ <%= link_to cities_path(country: @weather_art.city.country, state: @weather_art.city.state, region: @weather_art.city.country.region), class: "badge badge-lg badge-secondary hover:badge-outline transition-all duration-200" do %> <%= @weather_art.city.state.name %> <% end %> - <% elsif @weather_art.city.state.name.present? %> + <% elsif @weather_art.city.state.present? %>
<%= @weather_art&.city&.state&.name %>