From 2a0226eb683d5618d5e1efc6ba80cd6a9b267d18 Mon Sep 17 00:00:00 2001 From: songtianlun Date: Tue, 28 Jan 2025 01:32:56 +0800 Subject: [PATCH] feat: update sidekiq tasks manager for clarity - Rename task label from 'Batch Generate Weather Arts' to 'Generate Weather Arts' for better understanding. - Add a new button for manual task execution of 'BatchGenerateWeatherArts'. - Update task value in form submissions to be more descriptive, enhancing maintainability. These changes improve the usability of the Sidekiq tasks management interface, making it more intuitive for users to identify and execute tasks. The renamed button and the clear distinction between tasks aim to reduce confusion and assist in better workflow management. --- app/admin/sidekiq_jobs.rb | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/app/admin/sidekiq_jobs.rb b/app/admin/sidekiq_jobs.rb index 5fcb140..76f894e 100644 --- a/app/admin/sidekiq_jobs.rb +++ b/app/admin/sidekiq_jobs.rb @@ -1,16 +1,17 @@ # app/admin/sidekiq_tasks.rb ActiveAdmin.register_page "Sidekiq Tasks" do - menu label: "Sidekiq Tasks", priority: 99 + # menu label: "Sidekiq Tasks", priority: 99 + menu label: "Sidekiq Tasks Manager", parent: "系统管理" content title: "Sidekiq Tasks Management" do div class: "sidekiq-tasks" do panel "Manual Task Execution" do div class: "task-buttons" do div class: "task-button" do - h3 "Batch Generate Weather Arts" + h3 "Generate Weather Arts" form action: admin_sidekiq_tasks_run_task_path, method: :post do input type: "hidden", name: "authenticity_token", value: form_authenticity_token - input type: "hidden", name: "task", value: "BatchGenerateWeatherArtsWorker" + input type: "hidden", name: "task", value: "GenerateWeatherArtsWorker" select name: "city_id" do City.all.map do |city| option city.name, value: city.id @@ -20,6 +21,15 @@ ActiveAdmin.register_page "Sidekiq Tasks" do end end + div class: "task-button" do + h3 "Batch Generate Weather Arts" + form action: admin_sidekiq_tasks_run_task_path, method: :post do + input type: "hidden", name: "authenticity_token", value: form_authenticity_token + input type: "hidden", name: "task", value: "BatchGenerateWeatherArts" + input type: "submit", value: "Run Task", class: "button" + end + end + div class: "task-button" do h3 "Refresh Sitemap" form action: admin_sidekiq_tasks_run_task_path, method: :post do @@ -75,7 +85,9 @@ ActiveAdmin.register_page "Sidekiq Tasks" do city_id = params[:city_id] case task_name - when "BatchGenerateWeatherArtsWorker" + when "BatchGenerateWeatherArts" + BatchGenerateWeatherArtsWorker.perform_async + when "GenerateWeatherArtsWorker" GenerateWeatherArtWorker.perform_async(city_id) when "RefreshSitemapWorker" RefreshSitemapWorker.perform_async