songtianlun/today_ai_weather
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: simplify scope limit parameters

Browse Source 
- Change `limit:` to `limit =` in the scopes for
  `latest` and `by_popularity`.
- This allows for a default value of 100 to be used
  if no argument is provided, making the code more
  user-friendly and consistent.

This refactor does not alter the behavior of the
existing functionality but streamlines the syntax.
This commit is contained in:
songtianlun 2025-02-12 18:00:30 +08:00
parent 0a6926421f
commit afcb9c6cd8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/weather_art.rb
View File

@ -12,11 +12,11 @@ class WeatherArt < ApplicationRecord
validates :weather_date, presence: true validates :weather_date, presence: true
validates :city_id, presence: true validates :city_id, presence: true
scope :latest, ->(limit: 100) { scope :latest, ->(limit = 100) {
order(created_at: :desc).limit(limit) order(created_at: :desc).limit(limit)
} }
scope :by_popularity, ->(limit: 100) { scope :by_popularity, ->(limit = 100) {
if ActiveRecord::Base.connection.adapter_name.downcase == "sqlite" if ActiveRecord::Base.connection.adapter_name.downcase == "sqlite"
joins("LEFT JOIN ahoy_events ON json_extract(ahoy_events.properties, '$.weather_art_id') = weather_arts.id joins("LEFT JOIN ahoy_events ON json_extract(ahoy_events.properties, '$.weather_art_id') = weather_arts.id
AND json_extract(ahoy_events.properties, '$.event_type') = 'weather_art_view'") AND json_extract(ahoy_events.properties, '$.event_type') = 'weather_art_view'")