songtianlun/today_ai_weather
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: rename workers to jobs

Browse Source 
- Change class names from Worker to Job for better alignment
  with Rails convention.
- Includes changes in BatchGenerateWeatherArtsJob,
  CleanAhoyDataJob, GenerateWeatherArtJob, and
  RefreshSitemapJob classes.

This refactoring improves the clarity and consistency of the
codebase by adhering to established naming conventions,
making it easier for new developers to understand the
role of these classes within the application.
This commit is contained in:
songtianlun 2025-01-28 01:16:17 +08:00
parent ce5d09b621
commit bf2ff282bb
4 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/jobs/batch_generate_weather_arts_job.rb
View File

@ -1,5 +1,6 @@
class BatchGenerateWeatherArtsWorker # app/jobs/batch_generate_weather_arts_job.rb
include Sidekiq::Worker class BatchGenerateWeatherArtsJob < ApplicationJob
queue_as :default
GENERATION_INTERVAL = 24.hours GENERATION_INTERVAL = 24.hours
MAX_DURATION = 50.minutes MAX_DURATION = 50.minutes
@ -14,7 +15,7 @@ class BatchGenerateWeatherArtsWorker
break if Time.current - start_time > MAX_DURATION break if Time.current - start_time > MAX_DURATION
Rails.logger.info "Generating weather art for #{city.name}" Rails.logger.info "Generating weather art for #{city.name}"
GenerateWeatherArtWorker.perform_async(city.id) GenerateWeatherArtJob.perform_later(city.id)
sleep SLEEP_DURATION sleep SLEEP_DURATION
end end
end end
@ -33,4 +34,4 @@ class BatchGenerateWeatherArtsWorker
.where("latest_arts.last_generation_time IS NULL OR latest_arts.last_generation_time < ?", cutoff_time) .where("latest_arts.last_generation_time IS NULL OR latest_arts.last_generation_time < ?", cutoff_time)
.order(:priority) .order(:priority)
end end
end end

10
app/jobs/clean_ahoy_data_job.rb
View File

@ -1,8 +1,6 @@
# app/workers/clean_ahoy_data_worker.rb # app/jobs/clean_ahoy_data_job.rb
class CleanAhoyDataWorker class CleanAhoyDataJob < ApplicationJob
include Sidekiq::Worker queue_as :default
sidekiq_options queue: :default, retry: false
def perform def perform
cleanup_old_events cleanup_old_events
@ -29,4 +27,4 @@ class CleanAhoyDataWorker
Rails.logger.info "Remaining events: #{Ahoy::Event.count}" Rails.logger.info "Remaining events: #{Ahoy::Event.count}"
Rails.logger.info "Remaining visits: #{Ahoy::Visit.count}" Rails.logger.info "Remaining visits: #{Ahoy::Visit.count}"
end end
end end

4
app/jobs/generate_weather_art_job.rb
View File

@ -1,5 +1,5 @@
class GenerateWeatherArtWorker class GenerateWeatherArtJob < ApplicationJob
include Sidekiq::Worker queue_as :default
def perform(city_id) def perform(city_id)
@city = City.find(city_id) @city = City.find(city_id)

4
app/jobs/refresh_sitemap_job.rb
View File

@ -1,5 +1,5 @@
class RefreshSitemapWorker class RefreshSitemapJob < ApplicationJob
include Sidekiq::Worker queue_as :default
def perform def perform
host = Rails.env.production? ? "https://todayaiweather.com" : "http://127.0.0.1:3000" host = Rails.env.production? ? "https://todayaiweather.com" : "http://127.0.0.1:3000"