BUG: checkMesh, moveDynamicMesh checks not in postProcessing/ (fixes #1104)

- now placed under postProcessing/checkMesh and postProcessing/checkAMI,
  respectively.

  Output files are now also tagged with the id of the patch, in case
  there are multiple AMI patches in use.

applications/utilities/mesh/manipulation/checkMesh/checkGeometry.C

@@ -964,6 +964,13 @@ Foam::label Foam::checkGeometry
           : patchWriter()
         );
 
+        // Currently only do AMI checks
+
+        const fileName outputDir
+        (
+            mesh.time().globalPath()/functionObject::outputPrefix/"checkMesh"
+        );
+
         forAll(pbm, patchi)
         {
             if (isA<cyclicAMIPolyPatch>(pbm[patchi]))
@@ -1021,8 +1028,11 @@ Foam::label Foam::checkGeometry
                         {
                             wr.write
                             (
-                                functionObject::outputPrefix,
-                                "src_" + tmName,
+                                outputDir,
+                                (
+                                    "patch" + Foam::name(cpp.index())
+                                  + "-src_" + tmName
+                                ),
                                 meshedSurfRef
                                 (
                                     mergedPoints,
@@ -1054,8 +1064,11 @@ Foam::label Foam::checkGeometry
                             {
                                 wr.write
                                 (
-                                    functionObject::outputPrefix,
-                                    "src_" + tmName,
+                                    outputDir,
+                                    (
+                                        "patch" + Foam::name(cpp.index())
+                                      + "-src_" + tmName
+                                    ),
                                     meshedSurfRef
                                     (
                                         mergedPoints,
@@ -1109,8 +1122,11 @@ Foam::label Foam::checkGeometry
                         {
                             wr.write
                             (
-                                functionObject::outputPrefix,
-                                "tgt_" + tmName,
+                                outputDir,
+                                (
+                                    "patch" + Foam::name(cpp.index())
+                                  + "-tgt_" + tmName
+                                ),
                                 meshedSurfRef
                                 (
                                     mergedPoints,
@@ -1142,8 +1158,11 @@ Foam::label Foam::checkGeometry
                             {
                                 wr.write
                                 (
-                                    functionObject::outputPrefix,
-                                    "tgt_" + tmName,
+                                    outputDir,
+                                    (
+                                        "patch" + Foam::name(cpp.index())
+                                      + "-tgt_" + tmName
+                                    ),
                                     meshedSurfRef
                                     (
                                         mergedPoints,

applications/utilities/mesh/manipulation/checkMesh/checkTools.C

@@ -284,8 +284,7 @@ void Foam::mergeAndWrite
 
     fileName outputDir
     (
-        set.time().path()
-      / (Pstream::parRun() ? ".." : "")
+        set.time().globalPath()
       / functionObject::outputPrefix
       / mesh.pointsInstance()
       / set.name()
@@ -378,8 +377,7 @@ void Foam::mergeAndWrite
 
     fileName outputDir
     (
-        set.time().path()
-      / (Pstream::parRun() ? ".." : "")
+        set.time().globalPath()
       / functionObject::outputPrefix
       / mesh.pointsInstance()
       / set.name()
@@ -478,8 +476,7 @@ void Foam::mergeAndWrite
         // postProcessing/<time>/p0.vtk
         fileName outputDir
         (
-            set.time().path()
-          / (Pstream::parRun() ? ".." : "")
+            set.time().globalPath()
           / functionObject::outputPrefix
           / mesh.pointsInstance()
           // set.name()

applications/utilities/mesh/manipulation/moveDynamicMesh/moveDynamicMesh.C

@@ -116,6 +116,11 @@ void writeWeights
 
 void writeWeights(const polyMesh& mesh)
 {
+    const fileName outputDir
+    (
+        mesh.time().globalPath()/functionObject::outputPrefix/"checkAMI"
+    );
+
     for (const polyPatch& pp : mesh.boundaryMesh())
     {
         if (isA<cyclicAMIPolyPatch>(pp))
@@ -137,8 +142,8 @@ void writeWeights(const polyMesh& mesh)
                     mesh,
                     ami.tgtWeightsSum(),
                     cpp.neighbPatch(),
-                    functionObject::outputPrefix,
-                    "tgt",
+                    outputDir,
+                    "patch" + Foam::name(pp.index()) + "-tgt",
                     mesh.time()
                 );
                 writeWeights
@@ -146,8 +151,8 @@ void writeWeights(const polyMesh& mesh)
                     mesh,
                     ami.srcWeightsSum(),
                     cpp,
-                    functionObject::outputPrefix,
-                    "src",
+                    outputDir,
+                    "patch" + Foam::name(pp.index()) + "-src",
                     mesh.time()
                 );
             }
@@ -170,7 +175,7 @@ int main(int argc, char *argv[])
     #include "createTime.H"
     #include "createNamedDynamicFvMesh.H"
 
-    const bool checkAMI  = args.found("checkAMI");
+    const bool checkAMI = args.found("checkAMI");
 
     if (checkAMI)
     {

src/mesh/snappyHexMesh/meshRefinement/meshRefinement.C

@@ -2285,8 +2285,7 @@ Foam::label Foam::meshRefinement::findRegions
                 if (Pstream::master())
                 {
                     outputDir =
-                        mesh.time().path()
-                      / (Pstream::parRun() ? ".." : "")
+                        mesh.time().globalPath()
                       / functionObject::outputPrefix
                       / mesh.pointsInstance();
                     outputDir.clean();

src/sampling/sampledSet/shortestPath/shortestPathSet.C

@@ -844,8 +844,7 @@ Foam::shortestPathSet::shortestPathSet
         if (Pstream::master())
         {
             outputDir =
-                mesh.time().path()
-              / (Pstream::parRun() ? ".." : "")
+                mesh.time().globalPath()
               / functionObject::outputPrefix
               / mesh.pointsInstance();
             outputDir.clean();