Commit Graph

23463 Commits

Author SHA1 Message Date
mattijs
f65a95a68e COMP: g++11: suppress optimisation. See #3024 2024-01-19 21:17:08 +01:00
mattijs
344237b289 BUG: mapFields: incorrect patches. Fixes #2944. 2023-08-31 09:43:29 +02:00
Mark Olesen
b1d6297976 BUG: UPstream::shutdown misbehaves with external initialisation (fixes #2808)
- freeCommmunicatorComponents needs an additional bounds check.
  When MPI is initialized outside of OpenFOAM, there are no
  UPstream communicator equivalents
2023-06-20 09:42:12 +02:00
Kutalmis Bercin
008d015689 Revert "BUG: Fixing ray dAve and omega for 1D and 2D cases"
This reverts commit 5848b0afd5.
2023-06-20 09:41:12 +02:00
Mark Olesen
0fcd1446c5 BUG: VTK write pointSet fails in parallel (fixes #2773)
- de-referenced autoPtr with () instead of ref() will fail on
  non-master ranks.
2023-05-05 15:58:16 +02:00
Mark Olesen
70451e680c COMP: code adjustments for gcc-13 (#2714) 2023-02-28 16:31:01 +01:00
Mark Olesen
5768a7e9c8 CONFIG: accept module-prefix 'none' as equivalent to 'false' (ie, disabled) 2023-02-28 16:31:01 +01:00
Mark Olesen
56de3901e2 BACKPORT: align wmake have_* scripts with v2006
- simplify maintenance
2023-02-28 16:31:01 +01:00
Mark Olesen
36453aa9af BACKPORT: adjust wmake/scripts/*Functions according to v2006
- simplifies maintenance of detection scripts
2023-02-28 16:31:01 +01:00
Kutalmis Bercin
dd06e6448c BUG: solitaryWaveModel: avoid reference access to an operand object (Fixes #2178) 2022-08-24 10:04:52 +01:00
Mark Olesen
74ff53cd88 BUG: incorrect order for output scaling (transformPoints, ...)
- the output write scaling should be applied *after* undoing the
  effects of the specified rotation centre. Fixes #2566

ENH: update option names for transformPoints and surfaceTransformPoints

- prefer  '-auto-centre' and '-centre', but also accept the previous
  options '-auto-origin' and '-origin' as aliases.

  Changing to '-centre' avoids possible confusion with
  coordinate system origin().
2022-08-18 13:56:13 +02:00
Mark Olesen
173ce8511f CONFIG: bump patch level 2022-06-24 17:28:02 +02:00
Andrew Heather
e93f3f6812 COMP: Gcc 11+ potential fix - see #2434 2022-06-24 17:28:02 +02:00
Mark Olesen
1949a31efb COMP: references to temporaries
COMP: include <limits>
2022-06-24 17:28:02 +02:00
Mark Olesen
eb3f7dfe74 COMP: gcc-12 buffer check bypasses xsputn (#2481, #2496)
- add overflow() method to the SHA1 streambuf. Previously could rely
  on xsputn for adding to sha1 content, but streams now check pptr()
  first to test for the buffering range and thus overflow() is needed.
2022-06-24 17:28:02 +02:00
Mark Olesen
2a3fd5afb4 BUG: sample/store surface field triggers dimension check (fixes #2361)
- when used for example with wallShearStress, the stress field is
  initially created as incompressible but later updated with the
  correct compressible/incompressible dimensions.

  If this field is sampled as a surface and stored on the registry
  the dimensions should be reset() and not '=' assigned, since that
  causes a dimension check which will obviously fail.
2022-02-11 14:36:58 +01:00
Mark Olesen
06f14de0cd CONFIG: bump patch level 2021-09-08 15:25:51 +02:00
Mark Olesen
1ead175957 BUG: error with empty distributed roots specification (fixes #2196) 2021-09-08 10:31:18 +02:00
Andrew Heather
2fe9481262 BUG: ParticleCollector - corrected and simplified parallel reductions. See #2184 2021-09-08 10:31:18 +02:00
Mark Olesen
76270c07a0 BUG: noise did not set num of output fields (VTK legacy) [fixes #2133] 2021-06-25 09:45:53 +02:00
Andrew Heather
9d5585d37a BUG: liquidProperties - corrected read scalar (was label). See #2142 2021-06-25 09:44:26 +02:00
Mark Olesen
e1201d735f COMP: sign check to avoid warnings about new[] range 2021-04-27 11:12:43 +02:00
Mark Olesen
9aea491e58 CONFIG: bump patch level 2021-04-14 20:11:44 +02:00
Mark Olesen
00709429a5 BACKPORT: installation helpers from v2012
BACKPORT: AllwmakeParseArguments prefix handling from v2012
2021-04-14 20:00:00 +02:00
Mark Olesen
864271b118 BUG: generic point patch fails (fixes #2062)
- the generic constructor could be called twice in pointPatchField::New,
  which results in an attempt to transfer tokens twice.
2021-04-14 19:45:57 +02:00
Andrew Heather
5790fbe2a4 BUG: AABBTree - corrected addressing. Fixes #2028 2021-04-14 19:44:35 +02:00
Mark Olesen
10b9467f68 BUG: surfaceFieldValue fails writing legacy VTK format
- number of fields was not set.
- interpolated surfaces incorrectly written for all formats
2021-01-22 16:31:16 +01:00
Mark Olesen
f89de2b65c BUG: incorrect returned size from surfaceWriter 2021-01-13 18:54:01 +01:00
Andrew Heather
cd2787d452 BUG: meshToMesh - corrected mapping of internal field for tgt->src mapping. Fixes #1935 2020-11-25 12:44:04 +01:00
Mark Olesen
625f5f6cbb BUG: typo in solidProperties prevents re-reading of "Hf" (fixes #1927) 2020-11-18 19:40:21 +01:00
Mark Olesen
d19515bfb8 BUG: extraneous brackets after Fluent cell types (fixes #1872)
ENH: limit output to 25 cell types per line for readability

- makes it easier to trace potential format errors etc

STYLE: downgrade warning about polyhedrals to a simple info message

- can assume that polyhedral support is widespread enough to not
  warrant a warning.
2020-10-29 11:24:21 +01:00
Mark Olesen
1ea4fc986b BUG: incorrect boundary type for expressions variables (fixes #1889)
- had calculated boundaries (default) for the evaluated variables,
  which meant they retained their initialized values (usually Zero).

  This normally goes unnoticed, since the boundary values are largely
  irrelevant in the volField expressions. However, when applying
  functions that balk at a zero value - eg, log() - this raises a
  floating point exception.

  These boundary should be zeroGradient, since the evaluated variables
  correspond to the internalField only. Could continue to use
  calculated, but then need to set the calculated boundary values from
  the patch internal field manually.
2020-10-23 11:34:13 +02:00
Mark Olesen
e3ac8fb4f4 BUG: using FatalIOErrorInLookup with incorrect exit type (fixes #1898)
- two occurrences where FatalIOErrorInLookup used exit(FatalError)
  instead of exit(FatalIOError), which caused the error messages
  to be lost.
2020-10-23 11:33:49 +02:00
Mark Olesen
be6756f322 CONFIG: ptscotch header not found on ArchLinux (fixes #1877)
- on ArchLinux, everything is installed under /usr/include/scotch.

  The detection script uses SCOTCH_ARCH_PATH as an initial guess for
  ptscotch as well. However, on the second pass, it has an absolute
  value ("/usr") instead of a logical one ("scotch-system").
  This resulted in the logic for handling scotch+ptscotch subdirs
  being bypassed.
2020-10-12 10:49:20 +02:00
Mark Olesen
f85e798532 BUG: parallel foamToEnsight fails depending on lagrangian order (fixes #1873)
- the problem arises when output fields are missing on some
  processors.

  When the information is combined, the resulting HashTables can have
  different insertion orders. This poses an issue when there are hash
  key collisions and thus different chaining.

- Use sorted order.
2020-10-08 18:30:17 +02:00
mattijs
240342b508 BUG: mapPolyMesh: incorrect addressing. Fixes #1864
Triggered when running e.g. postProcess
2020-09-30 13:17:52 +02:00
Mark Olesen
4ffea147dc CONFIG: increment patch level 2020-09-24 13:46:55 +02:00
Mark Olesen
4e884c03d2 BUG: unexpected treatment of missing fractionExpr (fixes #1858)
- specifying gradientExpr without a valueExpr, a missing fractionExpr
  should be treated as 0 (gradient only), not as 1 (value only)

ENH: improve sanity checks + evaluation short-cuts in exprMixedFvPatchField
2020-09-24 13:46:52 +02:00
Mark Olesen
6c7ae09251 BUG: fractionExpr "0" ignored (fixes #1855)
- incorrect branching logic caused the "0" case to be ignored
2020-09-24 13:10:02 +02:00
Mark Olesen
7795f32fa6 BUG: gradingDescriptor stream input ignores negative expansion (Fix #1841)
- mostly only tripped when using fractional edge grading, since this
  is where the list reading is used. Overseen in commit 7da0b5bee1.
2020-09-16 09:32:27 +02:00
Mark Olesen
14410a736a BUG: directory information spoils "wmake -show-cxx" (fixes #1799)
- the various information queries MUST be executed with
  the '--no-print-directory' or risk polluting values
  in the information queries.

  This is mostly seen with the 'canCompile' test for tutorials running
  in parallel.
2020-08-06 17:58:19 +02:00
Mark Olesen
76137138ae CONFIG: increment patch level 2020-07-27 11:27:21 +02:00
Mark Olesen
1f83f48f3c BUG: potential memory leaks in HashPtrTable::set (#1787)
- backported fix from develop

COMP: incorrect variable names in PtrListOpsTemplates.C
2020-07-27 11:26:09 +02:00
Mark Olesen
bc58837658 STYLE: remove incorrect branch condition in setExprFields 2020-07-27 11:25:53 +02:00
Mark Olesen
51dd8f1c63 CONFIG: increment patch level 2020-06-26 10:35:55 +02:00
Mark Olesen
6534245359 BUG: incorrect lookup name in ReynoldsAnalogy (fixes #1751)
- used fluidThermo::typeName instead of fluidThermo::dictName
  within the Cp() method.
2020-06-26 10:32:13 +02:00
sergio
b6bf3502a3 BUG: Adding phasePropertyName to basicThermo constructor (fixes #1745) 2020-06-26 10:32:13 +02:00
sergio
c49d923392 BUG: Correcting htc definition to avoid negative values 2020-06-26 10:32:13 +02:00
Mark Olesen
4248fdcd96 BUG: windows IOobject::path() incorrect from absolute (fixes #1738)
- only checked if it started with '/' and not 'd:/' (for example).
2020-06-26 10:32:13 +02:00
Mark Olesen
8f8617a8ca CONFIG: increment patch level 2020-06-04 21:49:35 +02:00