Commit Graph

215 Commits

Author SHA1 Message Date
Henry
b3cde56f27 Doxygen docs: Corrected doxyFilter to preserve line numbers
Also corrected many formatting errors in the comments in C and H files
2011-02-07 22:50:49 +00:00
andy
62ca98ac38 BUG: (typo) one too many )'s 2011-01-17 15:57:07 +00:00
andy
eaef8d482b STYLE: Updated 1991 start copyright year to 2004 2011-01-14 16:08:00 +00:00
andy
05022c373a STYLE: minor formatting 2011-01-14 15:44:00 +00:00
andy
099cc39e2e Revert "STYLE: 2011 copyright date."
This reverts commit b18f6cc1ce.
2011-01-05 18:24:29 +00:00
graham
b18f6cc1ce STYLE: 2011 copyright date. 2011-01-05 11:14:26 +00:00
Mark Olesen
da439f5484 STYLE: consistent naming for templated/non-templated patch field construction
eg,
    - makePatchTypeField -> makeTemplatePatchTypeField
    - makeNonTemplatedPatchTypeField -> makePatchTypeField
2010-12-30 09:36:09 +01:00
Mark Olesen
881b3dafa2 Merge remote branch 'OpenCFD/master' into olesenm
Conflicts:
	applications/solvers/multiphase/twoPhaseEulerFoam/kineticTheoryModels/kineticTheoryModel/kineticTheoryModel.C
	applications/utilities/mesh/generation/extrude/extrudeToRegionMesh/createShellMesh.C
	applications/utilities/surface/surfaceCheck/surfaceCheck.C
	src/finiteVolume/fields/fvPatchFields/derived/advective/advectiveFvPatchField.C
	src/finiteVolume/fields/fvPatchFields/derived/waveTransmissive/waveTransmissiveFvPatchField.C
	src/meshTools/directMapped/directMappedPolyPatch/directMappedPatchBase.C

NOTE: also needed to strip trailing space/lines in various files
2010-12-21 10:19:53 +01:00
Mark Olesen
078c427594 COMP: avoid ambiguous construct from tmp - solvers/ multiphase 2010-12-21 09:53:19 +01:00
mattijs
cde4e66674 STYLE: kineticTheoryModel.C : line length 2010-12-15 17:06:23 +00:00
mattijs
1473e9f2ef COMP: kineticTheroyModel : single precision compilation 2010-12-15 15:25:11 +00:00
Mark Olesen
8b59f1d0d5 Merge remote branch 'OpenCFD/master' into olesenm 2010-11-08 08:07:29 +01:00
Henry
f8ae2453df chtMultiRegionFoam: updated thermodynamics 2010-11-02 18:57:39 +00:00
Mark Olesen
d5acd22a63 STYLE: use labelUList typedef instead of UList<label> or unallocLabelList 2010-11-02 09:32:32 +01:00
Henry
1fe653ac36 LTSInterFoam: Allow the new time-step smoothing parameters to be input 2010-11-01 14:45:04 +00:00
Henry
f12b86310f multiphaseMixture: Corrected EXE_LIBS -> LIB_LIBS 2010-10-29 13:09:09 +01:00
andy
667b5c13ae Merge branch 'master' of ssh://noisy/home/noisy3/OpenFOAM/OpenFOAM-dev 2010-10-26 11:54:27 +01:00
andy
4f8ea8d6af BUG: Incorrect lookup name for alphak 2010-10-26 11:53:56 +01:00
Henry
730481aed3 LTSInterFoam: Initial version of interFoam supporting local time-stepping for acceleration to steady-state 2010-10-25 17:49:56 +01:00
Henry
c078ab9dee DSMC tutorials: remove temporary files 2010-10-13 17:08:10 +01:00
Henry
5dc9b66ba3 New Courant number now implemented in most solvers
CHT solvers still to do
2010-10-13 13:09:24 +01:00
Henry
eb51614780 Renamed rUA -> rAU 2010-10-11 20:10:34 +01:00
Henry
ad3abe3738 Courant Numbers: Corrected reductions for parallel running 2010-10-10 23:19:16 +01:00
Henry
195510935d Courant number: new formulation
Improves boundary handling
Corresponds better to FVM equations
2010-10-08 22:52:18 +01:00
Henry
89ee9b3e0f Merged all multiphase developments in OpenFOAM-1.7.x 2010-09-29 22:22:48 +01:00
Henry
ad925d65d2 threePhaseMixture: corrected typo 2010-09-29 11:19:48 +01:00
Henry
7428b36de8 incompressibleThreePhaseMixture: Corrected the construction of the third-phase properties 2010-09-29 10:50:03 +01:00
Henry
5a655495dc bubbleFoam: Cleaned-up createPhi 2010-09-29 10:49:35 +01:00
sergio
08a9c9da8f BUG: ID 0000028 Inconsistency in nuEffa declaration 2010-09-07 09:38:11 +01:00
sergio
fee00dbef0 BUG : constant::mathematical::pi 2010-09-06 14:29:41 +01:00
sergio
7343f95afb STY: line exceeding 80 characthers. 2010-09-06 11:28:26 +01:00
sergio
8f1a350758 ENH: Improvements on kinetic theory models and twoPhaseEulerFoam 2010-09-06 11:24:22 +01:00
graham
28345247a7 STYLE: Fixing code style requirements for more files - those not
picked up by a copyright change.
2010-07-29 11:28:44 +01:00
graham
012494fdb5 STYLE: Fixing code style requirements for all apps.
Exception: applyWallFunctionBoundaryConditions.C cannot split #include
directives.
2010-07-27 15:27:05 +01:00
mattijs
f6670f8dec COMP: Make/options added indirect libs for Solaris linker. 2010-07-15 09:38:52 +01:00
henry
ccfb6e32a6 Corrected headers. 2010-06-23 16:54:54 +01:00
henry
17d36e9353 multiphaseInterFoam: changed alphaContactAngleFvPatchScalarField to multiphaseAlphaContactAngleFvPatchScalarField
to avoid name clashed with the version of alphaContactAngleFvPatchScalarField in the interfaceProperties library.
2010-06-10 12:53:54 +01:00
andy
28b1a9e2c6 Merge branch 'olesenm' 2010-06-03 10:25:03 +01:00
mattijs
f1ee573aa0 Merge branch 'inotify'
Conflicts:
	TODO
2010-06-02 10:10:52 +01:00
mattijs
c51a2b0f63 ENH: have MUST_READ_IF_MODIFIED on IOdictionary construction 2010-06-02 09:48:07 +01:00
henry
361b153343 Final iteration information now available in mesh::data (used to be mesh::fvData)
Relaxation and solution parameters for the final iteration in PIMPLE loops are
now selected according to the value of the "finalIteration" entry in the
mesh::data dictionary.

rhoPimpleFoam significantly updates and now replaces rhoPisoFoam.
2010-05-25 18:45:25 +01:00
henry
bcfa40c405 interMixingFoam: corrected the slicing of allLambda for parallel running. 2010-05-19 22:48:54 +01:00
Mark Olesen
f9f988d82f Merge remote branch 'OpenCFD/master' into olesenm
Conflicts:
	src/finiteVolume/fields/fvPatchFields/derived/timeVaryingMappedFixedValue/timeVaryingMappedFixedValueFvPatchField.C
2010-05-31 11:50:56 +02:00
Mark Olesen
ff30e6b61a STYLE: can use bool instead of Switch version of dictionary::lookupOrDefault
- both versions handle the same input words.
  Only need the <Switch> version when the destination variable is
  also a Switch and we need to output the word later.
2010-05-20 14:17:18 +02:00
Mark Olesen
9525d57d71 STYLE: use readIfPresent instead of found/lookup combination 2010-05-20 08:52:45 +02:00
Mark Olesen
80b8071e75 ENH: add default control values to ease SIMPLE->PIMPLE transition
- add const-ness for control variables

- drop unused fluxGradp variable

- use lookupOrDefault instead of found/lookup combination
2010-05-20 08:24:55 +02:00
andy
ccf61a7db8 Revert "STYLE: remove unneed '()' for simple return statements,"
This reverts commit c600ce545d.
2010-05-18 14:30:53 +01:00
Mark Olesen
c600ce545d STYLE: remove unneed '()' for simple return statements,
- fix 'forAll (' -> 'forAll(' format (again)
2010-05-17 13:08:11 +02:00
Mark Olesen
9c32ce1016 STYLE: use forAll macro in more places, avoid LF-CR endings 2010-04-23 18:35:55 +02:00
Mark Olesen
03338b9ea9 STYLE: partial revert for 5cfa97624e 2010-04-23 10:23:08 +02:00
Mark Olesen
5cfa97624e STYLE: more consistent New methods, use unregistered IOobject where appropriate 2010-04-20 17:13:35 +02:00
Mark Olesen
937e0d23d0 STYLE: consistent naming of files containing the 'New' method
before:
    - 'new' prefixed to camel-cased class name: eg, someClass -> newSomeClass
    - 'New' prefixed to templated class name:   eg, TmplClass -> NewTmplClass
    - 'New' suffixed to class name:             eg, someClass -> someClassNew

after:
    - consistent 'New' suffixed to class name, no change of case
          eg, someClass -> someClassNew
          eg, TmplClass -> TmplClassNew
2010-04-13 18:47:47 +02:00
Mark Olesen
42807ddd7e STYLE: fix worst spacing violations for 'os <<' constructions
- accept some violations of the coding guidelines though
- perhaps adding a style exception would be simpler.
2010-04-13 17:45:49 +02:00
Mark Olesen
b6f3bd4c23 STYLE: follow coding guide recommendation for '//- Destructor' 2010-04-12 11:55:52 +02:00
Mark Olesen
c508b2fe17 STYLE: consistent capitalization of Private/Protected Member Functions in comments 2010-03-30 11:33:42 +02:00
Mark Olesen
d29c438657 STYLE: use url for FSF license instead of postal address, switch to GPL v3 2010-03-29 14:07:56 +02:00
Mark Olesen
0c8fb634f0 ENH: enforce consistent boundness on turbulence models.
- remove epsilonSmall, omegaSmall
- k0/epsilon0/omega0 become kMin/epsilonMin/omegaMin
- add qMin/zetaMin for consistency

These files still need some attention:
    dynOneEqEddy.C
    NonlinearKEShih.C
    settlingFoam

BUG: incompressible::LESModels:dynOneEqEddy::correct()
- avoid tmp field destruction for consistency with the compressible
  version

Possible TODO:
   - set kMin to zero (instead of SMALL) and introduce kSmall
     to avoid division by zero
2010-03-24 09:07:53 +01:00
henry
4f926a376f New solver: rhoPorousMRFPimpleFoam
Added compressibility support to MRFZone.
Required generalisation of the oneField concept.
Also clean-up the use of one and zero for consistency.
Simple mixerVessel2D tutorial case supplied.
2010-03-19 17:54:35 +00:00
henry
3b038c3702 settlingFoam: Changed to solving for pmh (static pressure minus hydrostatic pressure).
While p and pmh (pd in OpenFOAM-1.5.?) are equivalent on orthogonal meshes they
are not on non-orthogonal meshes and the difference is very important for
buoyancy-dominated flows such as settling.  settlingFoam is now written in terms
of pmh (static pressure minus hydrostatic pressure) which used to be called pd
but that confused too may people.
2010-01-28 16:06:08 +00:00
Mark Olesen
5e972c772f remove trailing space from some files 2009-12-04 13:39:35 +01:00
Mark Olesen
c091d856ae pedantic changes: 'forAll (' -> 'forAll(' in applications/
- to match coding guidelines
2009-12-03 14:12:08 +01:00
Mark Olesen
909e6b27e4 Apply coding style recommendations:
- space between keyword and bracket in 'for(..)', 'if(..)', 'while(..)'
2009-11-30 08:55:03 +01:00
Mark Olesen
fa93ce8cd7 coding style adherence
- markup codingStyleGuide.org examples so they actually indent correctly

- use 'Info<<' as per codingStyleGuide instead of 'Info <<'
2009-11-27 15:39:14 +01:00
henry
bb65911c45 Added a correction to the boundary velocity and flux to make them consistent
with the boundary motion before the fluxes are corrected for continuity by
pcorr.
2009-11-18 23:10:26 +00:00
henry
9bb3c1c1ba New solvers and tutorial cases transferred from OpenFOAM-1.6.x. 2009-10-30 17:24:02 +00:00
graham
9221793088 Changing
deltaT().value() to deltaTValue()
and
    deltaT0().value() to deltaT0Value()
across the whole code - faster to return especially if being used
often, in each call to a submodel for example.
2009-10-21 16:36:07 +01:00
henry
e9da288118 Reverted the Americanism "math" back to the original "mathematical" and reverted name of
the include file back to mathematicalConstants.H to make upgrading code slightly easier.
2009-10-10 22:58:58 +01:00
mattijs
791b5aaeaa replacing isType with isA to enable directMappedWall to work 2009-09-15 17:51:59 +01:00
andy
8dcea0f8cd using new constant definitions 2009-08-28 18:04:22 +01:00
henry
c9be8d63de Added alternating stress term. 2009-08-18 17:12:38 +01:00
andy
9fb0ed08e7 updating turb coeffs + fix typo 2009-08-13 09:54:57 +01:00
henry
31c76da40f Changed the runtime-selection tables to output a sorted toc. 2009-08-06 18:01:28 +01:00
mattijs
73ae3ddc6d include topoChangerFvMesh 2009-08-05 21:31:30 +01:00
mattijs
e5a710d3eb Merge branch 'master' of /home/noisy3/OpenFOAM/OpenFOAM-dev 2009-08-05 16:18:38 +01:00
mattijs
eba6c985a9 added rawTopoFvChanger mesh 2009-08-05 16:11:47 +01:00
Mark Olesen
7a8a318312 Revert "define values for standardCmu, standardKappa, standardE in turbulenceModel.H"
This reverts commit 54a8b6a152.
2009-08-03 15:31:14 +02:00
Mark Olesen
54a8b6a152 define values for standardCmu, standardKappa, standardE in turbulenceModel.H 2009-08-01 09:36:34 +02:00
Mark Olesen
827e3659b9 consistency update: kappa=0.41, E=9.8
- this would be an argument for providing default values at the top-level
  compressible/incompressible turbulenceModel
2009-07-31 18:15:54 +02:00
andy
c1993c92fa Merge branch 'olesenm' 2009-07-23 12:42:52 +01:00
Chris Greenshields
2f3016173e Modified Description entries for documenting purposes 2009-07-22 14:08:02 +01:00
Mark Olesen
5692a06a32 fixed up sloppy Allwclean files 2009-07-22 12:39:20 +02:00
henry
b3d455de80 Removed turbulence model coefficients from the dictionaries to allow them to default. 2009-07-21 19:05:30 +01:00
henry
5a83c4660c Added rho for the buoyantPressure BC. 2009-07-10 14:42:23 +01:00
henry
d76820dc57 Changed g from being read from environmentalProperties to being read directly as a
uniformDimensionedVectorField.
2009-07-08 17:09:51 +01:00
henry
4439183d96 Corrected handling of the wall BCs of p for buoyant flows. 2009-07-07 22:56:02 +01:00
andy
7d73dd3171 updates for new thermo and general code tidying 2009-06-15 15:36:57 +01:00
henry
e68480913f pd => p 2009-06-04 19:11:12 +01:00
henry
c593fa63e5 pd => p 2009-06-04 17:35:47 +01:00
henry
f20792493d New, improved with p rather than pd, PIMPLE rather than PISO and more general handling of the diffusivity. 2009-06-03 14:59:35 +01:00
henry
1002f8d07f Changed to use p rather than pd. 2009-06-03 14:58:30 +01:00
henry
20dcad4e57 Added the reciprocal of the turbulent Schmidt number. 2009-05-29 11:03:20 +01:00
henry
1d14951bf5 Added turbulent diffusivity. 2009-05-29 09:32:32 +01:00
henry
0ee817a060 Also added a separate specification of the static pressure level but the
location for the specification is the same as that for the pd level.
2009-05-11 23:19:56 +01:00
mattijs
adc012cab8 renamed ghf to prevent duplicate regIOobject 2009-04-17 12:23:05 +01:00
Mark Olesen
a46c85f5a4 HashTable changes
- make table power-of-two, but since it seems to give 1-2% performance
  improvement, maybe forget it too.

- remove two-argument form of hashing classes and do the modulus direclty
  within HashTable instead. This simplifies things a fair bit.

- migrate Hash<void*> from db/dlLibrary to primitives/hashes/Hash
2009-02-26 17:49:47 +01:00
Mark Olesen
4b60453cf1 use while (runTime.loop() { .. } where possible in solvers
- change system/controlDict to use functions {..} instead of functions (..);
  * This is internally more efficient
- fixed formatting of system/controlDict functions entry

- pedantic change: use 'return 0' instead of 'return(0)' in the applications,
  since return is a C/C++ keyword, not a function.
2009-02-18 08:57:10 +01:00
Mark Olesen
c2256e51f3 change solvers, utilities, etc. to use while (..) time-looping idiom
- this (now deprecated) idiom:
      for (runTime++; !runTime.end(); runTime++) { ... }
  has a few problems:
    * stop-on-next-write will be off-by-one (ie, doesn't work)
    * function objects are not executed on exit with runTime.end()
  Fixing these problems is not really possible.

- this idiom
      while (runTime.run())
      {
          runTime++;
          ...
      }
  works without the above problems.
2009-02-17 08:47:42 +01:00
mattijs
11176914d4 memory leak 2009-02-05 15:28:32 +00:00
andy
6d1466465b consistency update 2009-02-04 11:27:35 +00:00
andy
1bd5737782 remove spurious references to INTERFOAM 2009-01-13 18:44:27 +00:00