Mark Olesen
5cfa97624e
STYLE: more consistent New methods, use unregistered IOobject where appropriate
2010-04-20 17:13:35 +02:00
Mark Olesen
937e0d23d0
STYLE: consistent naming of files containing the 'New' method
...
before:
- 'new' prefixed to camel-cased class name: eg, someClass -> newSomeClass
- 'New' prefixed to templated class name: eg, TmplClass -> NewTmplClass
- 'New' suffixed to class name: eg, someClass -> someClassNew
after:
- consistent 'New' suffixed to class name, no change of case
eg, someClass -> someClassNew
eg, TmplClass -> TmplClassNew
2010-04-13 18:47:47 +02:00
Mark Olesen
42807ddd7e
STYLE: fix worst spacing violations for 'os <<' constructions
...
- accept some violations of the coding guidelines though
- perhaps adding a style exception would be simpler.
2010-04-13 17:45:49 +02:00
Mark Olesen
b6f3bd4c23
STYLE: follow coding guide recommendation for '//- Destructor'
2010-04-12 11:55:52 +02:00
Mark Olesen
c508b2fe17
STYLE: consistent capitalization of Private/Protected Member Functions in comments
2010-03-30 11:33:42 +02:00
Mark Olesen
d29c438657
STYLE: use url for FSF license instead of postal address, switch to GPL v3
2010-03-29 14:07:56 +02:00
Mark Olesen
0c8fb634f0
ENH: enforce consistent boundness on turbulence models.
...
- remove epsilonSmall, omegaSmall
- k0/epsilon0/omega0 become kMin/epsilonMin/omegaMin
- add qMin/zetaMin for consistency
These files still need some attention:
dynOneEqEddy.C
NonlinearKEShih.C
settlingFoam
BUG: incompressible::LESModels:dynOneEqEddy::correct()
- avoid tmp field destruction for consistency with the compressible
version
Possible TODO:
- set kMin to zero (instead of SMALL) and introduce kSmall
to avoid division by zero
2010-03-24 09:07:53 +01:00
henry
4f926a376f
New solver: rhoPorousMRFPimpleFoam
...
Added compressibility support to MRFZone.
Required generalisation of the oneField concept.
Also clean-up the use of one and zero for consistency.
Simple mixerVessel2D tutorial case supplied.
2010-03-19 17:54:35 +00:00
henry
3b038c3702
settlingFoam: Changed to solving for pmh (static pressure minus hydrostatic pressure).
...
While p and pmh (pd in OpenFOAM-1.5.?) are equivalent on orthogonal meshes they
are not on non-orthogonal meshes and the difference is very important for
buoyancy-dominated flows such as settling. settlingFoam is now written in terms
of pmh (static pressure minus hydrostatic pressure) which used to be called pd
but that confused too may people.
2010-01-28 16:06:08 +00:00
Mark Olesen
5e972c772f
remove trailing space from some files
2009-12-04 13:39:35 +01:00
Mark Olesen
c091d856ae
pedantic changes: 'forAll (' -> 'forAll(' in applications/
...
- to match coding guidelines
2009-12-03 14:12:08 +01:00
Mark Olesen
909e6b27e4
Apply coding style recommendations:
...
- space between keyword and bracket in 'for(..)', 'if(..)', 'while(..)'
2009-11-30 08:55:03 +01:00
Mark Olesen
fa93ce8cd7
coding style adherence
...
- markup codingStyleGuide.org examples so they actually indent correctly
- use 'Info<<' as per codingStyleGuide instead of 'Info <<'
2009-11-27 15:39:14 +01:00
henry
bb65911c45
Added a correction to the boundary velocity and flux to make them consistent
...
with the boundary motion before the fluxes are corrected for continuity by
pcorr.
2009-11-18 23:10:26 +00:00
henry
9bb3c1c1ba
New solvers and tutorial cases transferred from OpenFOAM-1.6.x.
2009-10-30 17:24:02 +00:00
graham
9221793088
Changing
...
deltaT().value() to deltaTValue()
and
deltaT0().value() to deltaT0Value()
across the whole code - faster to return especially if being used
often, in each call to a submodel for example.
2009-10-21 16:36:07 +01:00
henry
e9da288118
Reverted the Americanism "math" back to the original "mathematical" and reverted name of
...
the include file back to mathematicalConstants.H to make upgrading code slightly easier.
2009-10-10 22:58:58 +01:00
mattijs
791b5aaeaa
replacing isType with isA to enable directMappedWall to work
2009-09-15 17:51:59 +01:00
andy
8dcea0f8cd
using new constant definitions
2009-08-28 18:04:22 +01:00
henry
c9be8d63de
Added alternating stress term.
2009-08-18 17:12:38 +01:00
andy
9fb0ed08e7
updating turb coeffs + fix typo
2009-08-13 09:54:57 +01:00
henry
31c76da40f
Changed the runtime-selection tables to output a sorted toc.
2009-08-06 18:01:28 +01:00
mattijs
73ae3ddc6d
include topoChangerFvMesh
2009-08-05 21:31:30 +01:00
mattijs
e5a710d3eb
Merge branch 'master' of /home/noisy3/OpenFOAM/OpenFOAM-dev
2009-08-05 16:18:38 +01:00
mattijs
eba6c985a9
added rawTopoFvChanger mesh
2009-08-05 16:11:47 +01:00
Mark Olesen
7a8a318312
Revert "define values for standardCmu, standardKappa, standardE in turbulenceModel.H"
...
This reverts commit 54a8b6a152
.
2009-08-03 15:31:14 +02:00
Mark Olesen
54a8b6a152
define values for standardCmu, standardKappa, standardE in turbulenceModel.H
2009-08-01 09:36:34 +02:00
Mark Olesen
827e3659b9
consistency update: kappa=0.41, E=9.8
...
- this would be an argument for providing default values at the top-level
compressible/incompressible turbulenceModel
2009-07-31 18:15:54 +02:00
andy
c1993c92fa
Merge branch 'olesenm'
2009-07-23 12:42:52 +01:00
Chris Greenshields
2f3016173e
Modified Description entries for documenting purposes
2009-07-22 14:08:02 +01:00
Mark Olesen
5692a06a32
fixed up sloppy Allwclean files
2009-07-22 12:39:20 +02:00
henry
b3d455de80
Removed turbulence model coefficients from the dictionaries to allow them to default.
2009-07-21 19:05:30 +01:00
henry
5a83c4660c
Added rho for the buoyantPressure BC.
2009-07-10 14:42:23 +01:00
henry
d76820dc57
Changed g from being read from environmentalProperties to being read directly as a
...
uniformDimensionedVectorField.
2009-07-08 17:09:51 +01:00
henry
4439183d96
Corrected handling of the wall BCs of p for buoyant flows.
2009-07-07 22:56:02 +01:00
andy
7d73dd3171
updates for new thermo and general code tidying
2009-06-15 15:36:57 +01:00
henry
e68480913f
pd => p
2009-06-04 19:11:12 +01:00
henry
c593fa63e5
pd => p
2009-06-04 17:35:47 +01:00
henry
f20792493d
New, improved with p rather than pd, PIMPLE rather than PISO and more general handling of the diffusivity.
2009-06-03 14:59:35 +01:00
henry
1002f8d07f
Changed to use p rather than pd.
2009-06-03 14:58:30 +01:00
henry
20dcad4e57
Added the reciprocal of the turbulent Schmidt number.
2009-05-29 11:03:20 +01:00
henry
1d14951bf5
Added turbulent diffusivity.
2009-05-29 09:32:32 +01:00
henry
0ee817a060
Also added a separate specification of the static pressure level but the
...
location for the specification is the same as that for the pd level.
2009-05-11 23:19:56 +01:00
mattijs
adc012cab8
renamed ghf to prevent duplicate regIOobject
2009-04-17 12:23:05 +01:00
Mark Olesen
a46c85f5a4
HashTable changes
...
- make table power-of-two, but since it seems to give 1-2% performance
improvement, maybe forget it too.
- remove two-argument form of hashing classes and do the modulus direclty
within HashTable instead. This simplifies things a fair bit.
- migrate Hash<void*> from db/dlLibrary to primitives/hashes/Hash
2009-02-26 17:49:47 +01:00
Mark Olesen
4b60453cf1
use while (runTime.loop() { .. } where possible in solvers
...
- change system/controlDict to use functions {..} instead of functions (..);
* This is internally more efficient
- fixed formatting of system/controlDict functions entry
- pedantic change: use 'return 0' instead of 'return(0)' in the applications,
since return is a C/C++ keyword, not a function.
2009-02-18 08:57:10 +01:00
Mark Olesen
c2256e51f3
change solvers, utilities, etc. to use while (..) time-looping idiom
...
- this (now deprecated) idiom:
for (runTime++; !runTime.end(); runTime++) { ... }
has a few problems:
* stop-on-next-write will be off-by-one (ie, doesn't work)
* function objects are not executed on exit with runTime.end()
Fixing these problems is not really possible.
- this idiom
while (runTime.run())
{
runTime++;
...
}
works without the above problems.
2009-02-17 08:47:42 +01:00
mattijs
11176914d4
memory leak
2009-02-05 15:28:32 +00:00
andy
6d1466465b
consistency update
2009-02-04 11:27:35 +00:00
andy
1bd5737782
remove spurious references to INTERFOAM
2009-01-13 18:44:27 +00:00
Mark Olesen
cdd2266467
Merge commit 'OpenCFD/master' into olesenm
...
Conflicts:
src/OpenFOAM/db/IOstreams/Pstreams/IPstream.C
src/OpenFOAM/db/IOstreams/Pstreams/OPstream.C
2009-01-07 09:39:17 +01:00
henry
04d26c8e38
Corrected dimensions of kappa.
2009-01-05 22:17:20 +00:00
Mark Olesen
28b200bcd9
update copyrights for 2009
2008-12-31 19:01:56 +01:00
andy
468668d0be
muf -> muEff for consistency
2008-12-19 14:48:54 +00:00
andy
c5c622e1ab
adding pFinal
2008-12-19 14:45:28 +00:00
andy
9596677119
labelled muf - grad(muf) used, so can now manipulate in fvSolution etc
2008-12-19 14:03:49 +00:00
andy
dbe5e08213
minor mods:
...
- added pdFinal option
- labelled muf - grad(muf) used, so can now manipulate in fvSolution etc
- added absolute/relative around the calculation of divU
2008-12-19 13:59:05 +00:00
henry
9663072b5f
Removed ddtPhiCorr.
2008-12-12 15:06:04 +00:00
henry
1d22ab652e
Corrected the code for moving-mesh cases with dilatation.
2008-12-12 12:28:19 +00:00
henry
4d02f410b4
Moved setDeltaT to before the flux is made absolute.
2008-12-12 12:27:36 +00:00
henry
8d2bed91ce
Added ddtPhiCorr back into the pEqn, use if wisely.
2008-12-12 12:24:12 +00:00
henry
7f22e3104a
Added correctPhi to compressibleInterDyMFoam.
2008-12-11 12:05:21 +00:00
henry
0479165024
Added generic turbulenceModel base class to incompressible turbulence models.
2008-11-20 20:33:06 +00:00
henry
326b86ec2d
Added generic turbulenceModel base class to incompressible turbulence models.
2008-11-20 17:07:17 +00:00
Mark Olesen
d5d80f0181
modified remaining Allwmake scripts to run from anywhere
2008-09-19 14:47:06 +02:00
henry
00c9e2774d
Calculate p from pd.
2008-09-16 15:20:24 +01:00
henry
ffe9308432
Minor updates.
2008-09-03 08:34:04 +01:00
henry
d7a506c5f4
Added missing access function.
2008-08-05 13:21:52 +01:00
henry
f3f8ee3335
Fixed update of kappa_.
2008-08-04 16:17:49 +01:00
andy
e97b721db7
bugfix for lambda_
2008-07-30 15:32:51 +01:00
henry
352c0f4c24
Added turbulent viscosity.
2008-07-21 12:00:06 +01:00
henry
a86b1ce4a3
Corrected for SP.
2008-07-10 15:53:10 +01:00
andy
b2d7f8b5ca
removing redundant averaging files
2008-06-27 10:10:47 +01:00
andy
b4b75fc000
removing old averaging - replaced by averaging function object
2008-06-26 18:01:47 +01:00
Mark Olesen
02cabc3cf2
updated Copyright (C) \d+-2008 OpenCFD Ltd.
2008-06-25 15:01:46 +02:00
andy
b0f29324b2
minor fixes
2008-06-20 14:02:07 +01:00
andy
56fd8890d5
consistency updates
2008-06-20 11:22:33 +01:00
henry
adb7d5fb49
Bug fix:
...
http://openfoam.cfd-online.com/cgi-bin/forum/show.cgi?126/8089
2008-06-19 10:42:35 +01:00
henry
927de85fab
Merge branch 'master' of ssh://noisy/home/noisy2/OpenFOAM/OpenFOAM-dev
2008-06-18 23:11:55 +01:00
henry
ad19741845
Added kineticTheoryModels namespace and put the viscosityModels in it to
...
avoid name-clashes with the standard viscosityModels.
The other kineticTheoryModels have yet to be put in the kineticTheoryModels
namespace.
2008-06-18 23:11:09 +01:00
andy
b3cb7c3dd3
created incompressible namespace for incompressible LES models
2008-06-18 17:43:42 +01:00
andy
43786b44b8
update to recover previous usage for scheme descriptions
2008-06-18 12:57:18 +01:00
andy
eb1db26c8a
updated for change in coeff handling
2008-06-18 12:43:34 +01:00
andy
44af09b650
Merge branch 'master' of ssh://noisy/home/noisy2/OpenFOAM/OpenFOAM-dev
2008-06-18 10:22:51 +01:00
andy
2b01d2f5da
consistency update - (in)compressibleTurbulenceModels -> (in)compressibleRASmodels
2008-06-18 10:06:06 +01:00
henry
1efdd657bd
Updates to remove warning messages from gcc-4.3.1
2008-06-17 22:17:36 +01:00
andy
f4b2b04f58
consistency update
2008-06-17 17:28:12 +01:00
andy
4ddd3c67a6
updates to tuts to reflect turbulence changes, and general tut updates
2008-06-17 14:07:11 +01:00
andy
24c4b1b745
relocation of turbulence models and renaming namespaces
2008-06-17 10:48:04 +01:00
andy
168c7e1ca9
removing FoamX
2008-06-04 13:40:02 +01:00
henry
dd22a8d8a0
Implamented Rasmus' corrections to the particle force.
2008-05-28 22:38:03 +01:00
henry
9879aacb5a
Removed ddtPhiCorr as the standard approach does not work with
...
moving meshes
2008-05-27 22:51:14 +01:00
henry
3f20e26231
Reverting ddtPhiCorr back to standard (not good for moving meshes)
2008-05-27 17:13:35 +01:00
henry
4a2a23a710
Lots of changes from Mark and my changes to ddtPhiCorr all mixed together
...
because I failed to work out how to merge Mark's stuff -- HELP!!!
2008-05-25 21:46:37 +01:00
henry
28ac22a30e
Removed #.*#
2008-05-25 17:05:26 +01:00
mattijs
f36526531b
built into FOAM_USER_APPBIN
2008-05-22 14:07:02 +01:00
henry
cdb78d6741
There's a bug in Schaeffer's expression for the frictional viscosity,
...
which was pointed out by Rasmus.
The alpha[celli] term in muf should not be there.
2008-05-20 18:05:07 +01:00
andy
238b126c6c
added small description line to solvers
2008-05-14 09:47:51 +01:00
henry
603860c051
Merge branch 'master' of /home/noisy2/OpenFOAM/OpenFOAM-dev/
2008-05-13 12:59:59 +01:00
henry
6913778c8b
Added compressibleLesInterFoam solver
2008-05-13 12:59:46 +01:00
andy
5d96cfa897
removed hard-coded averaging - can now use fieldAverage unction object
2008-05-13 11:23:28 +01:00
andy
1466446992
labelled muEff surfaceScalarField on construction
2008-05-13 11:13:24 +01:00
andy
62e1b23093
removing cavitatingFoam - behaviour can be recoved using rasCavitatingFoam etc
2008-05-13 11:07:10 +01:00
andy
17132c9560
removed over specification of rho and nu
2008-05-13 11:05:39 +01:00
andy
75f6b64ffe
adding les/ras cavitating solvers and barotropicCompressibilityModel library
2008-05-09 19:06:44 +01:00
andy
8ff486784d
adding ras/les cavitation solvers
2008-05-09 16:38:10 +01:00
henry
6fc7b06b19
Made ddtPhiCorr optional in moving-mesh solvers.
...
Controlled via the "ddtPhiCorr" switch in the PISO sub-dict,
defaults to false.
2008-05-09 12:48:45 +01:00
henry
793fec2521
Added ddtPhiCorr support for moving mesh
2008-05-09 11:47:33 +01:00
henry
66d672b92b
Added p
...
Updated formatting
2008-05-07 22:51:12 +01:00
henry
f92fbeb9f9
Added p to interFoam
...
Changed formatting of interDyMFoam
2008-05-07 22:34:36 +01:00
henry
3e9f272de9
Corrected description
2008-05-07 17:07:54 +01:00
henry
ff6aa6d4e8
Reformatted #include consistently
2008-05-07 11:50:01 +01:00
henry
2c4d8c65d4
Improved description
2008-05-02 14:37:25 +01:00
henry
91e7cab0e3
Add interPhaseChangeFoam solver
2008-05-02 14:07:33 +01:00
OpenFOAM-admin
3170c7c0c9
Creation of OpenFOAM-dev repository 15/04/2008
2008-04-15 18:56:58 +01:00