Commit Graph

23415 Commits

Author SHA1 Message Date
Mark Olesen
ae40bd9f9b STYLE: use guards for dictionary lookup() 2020-01-28 11:57:23 +01:00
Mark Olesen
500a3b62ca STYLE: declare generated methods for blockDescriptor
- remove stray, unused file
2020-01-28 11:57:23 +01:00
Mark Olesen
056fb32f8f SUBMODULE: update OpenQBMM, visualization 2020-01-28 11:57:22 +01:00
Mark Olesen
9338f0b860 ENH: adjust wrapping routines for new vtkCellArray definition
- the vtkCellArray internal structure was still largely oriented on
  the VTK legacy format, but has now been revised.
  https://gitlab.kitware.com/vtk/vtk/merge_requests/5682

  The `VTK_CELL_ARRAY_V2` define from vtkCellArray.h indicates
  that the newer version is being used.

* In VTK-8.2.0 and older, sizes are interwoven (prefixed) in the
  connectivity.

  Connectivity: [n1, verts..., n2, verts... ]

  When using these in vtkUnstructuredGrid, also needed a secondary
  list of offsets for each of the starting locations.

* The update version now resembles a CompactListList. For example

  Connectivity: [verts..., verts... ]
  Offsets:      [0, n1, n1+n2, n1+n2+n3... ]

  The offsets are properly handled within vtkCellArray, and dropped as
  an additional input for vtkUnstructuredGrid.
2020-01-28 11:57:22 +01:00
Mark Olesen
f4ee841c6d STYLE: adjust code format for trackingData
- rationalized some layout and comments
2020-01-23 17:10:39 +01:00
Mattijs Janssens
0a9295b219 Merge branch 'enh-streams' into 'develop'
ENH: stream adjustments

See merge request Development/openfoam!332
2020-01-23 15:43:56 +00:00
Mark Olesen
0ff0271392 ENH: stream adjustments
- make stream constructors explicit

- remove "using std::ifstream", "using std::iofstream" statements
  for a cleaner namespace.

* copy/move assignments for ITstream

* IStringStream: default construct and construct from std::string
  instead of Foam::string

- reduce some overhead in masterOFstream

- simplify Pstream handling of string variants (#1525)
2020-01-23 16:34:43 +01:00
Andrew Heather
2270f649d7 Merge branch 'submodule-visualization' into 'develop'
Submodule visualization

See merge request Development/openfoam!331
2020-01-23 14:24:31 +00:00
Mark Olesen
449ba56750 CONFIG: bump API to 2001 2020-01-23 14:22:27 +01:00
Mark Olesen
7cec644ea2 SUBMODULE: added visualization submodule
- this submodule (https://develop.openfoam.com/modules/visualization)
  consolidates VTK-related visualization routines:

    * catalyst
    * paraview-plugins
    * runTimePostProcessing

  A benefit of this is make it easier to mix and match
  different combinations of VTK/ParaView versions and capabilities
  (Eg, MESA, MPI etc).

The catalyst submodule is now obsolete
2020-01-23 14:22:27 +01:00
Mark Olesen
ae5c7dab36 DEFEATURE: remove runTimePostProcessing (migrate to submodule) 2020-01-23 14:22:26 +01:00
Mark Olesen
de57d2da7e DEFEATURE: remove paraview reader modules (migrate to submodule) 2020-01-23 14:04:23 +01:00
Mark Olesen
858f0f2ccc GIT: remove leading "modules/" qualifier on the OpenQBMM module name 2020-01-23 13:59:13 +01:00
Mark Olesen
a48d258ab8 Merge branch 'submodule-openqbmm' into 'develop'
SUBMODULE: added OpenQBMM submodule - see #1522

See merge request Development/openfoam!330
2020-01-23 12:39:55 +00:00
Andrew Heather
54f8098014 SUBMODULE: added OpenQBMM submodule - see #1522
OpenQBMM is a suite of solvers to simulate polydisperse multiphase flows using
Quadrature-Based Moment Methods (QBMM).  For more information, please see
https://www.openqbmm.org/

Main author: Alberto Passalacqua
2020-01-23 12:36:53 +00:00
Mark Olesen
42c8bbf6d3 GIT: update submodule references 2020-01-23 13:15:18 +01:00
Mark Olesen
860e7df50b ENH: use DetailInfo for fileOperation I/O information
- allows suppression when the banner is suppressed
2020-01-22 20:46:37 +01:00
Mark Olesen
16e8d29476 CONFIG: handle different paraview (paraFoam) module names
For example,
  - ParaFoamReader     = (paraview >= 5.7)
  - libParaFoamReader  = (paraview < 5.7) and (OPENFOAM > 1912)
  - libPVFoamReader_SM = (OPENFOAM <= 1912)
2020-01-22 17:29:37 +01:00
Mark Olesen
59ed3ba18d ENH: consistency improvements for interpolationTable, table readers
- avoid stealing autoPtr in interpolationTable copy operations

- improve local memory requirements of readers

- make OpenFOAM table reader default constructible

- more code alignment between csvTableReader and Function1::CSV
  (fix #1498 for csvTableReader as well)
2020-01-21 15:17:04 +01:00
Mark Olesen
ee96dba0cf STYLE: simplify Random constructors
COMP: use generated methods in a few more places
2020-01-21 12:12:44 +01:00
Mark Olesen
d7c18a328c STYLE: simplify/shorten some token names 2020-01-20 10:15:50 +01:00
Mark Olesen
21456b8cdc BUG: verbatim token output strips type (#1497)
- use os::write(token) for verbatim string to preserve its type
2020-01-20 10:09:58 +01:00
Mark Olesen
5d33586864 STYLE: use constexpr for static const char strings 2020-01-17 10:15:57 +01:00
Mark Olesen
f0be8679f6 ENH: provide defaultName() static method for patches, zones
- consistent way of writing "patch" + Foam::name(id) etc.
2020-01-16 13:24:23 +01:00
Mark Olesen
2a98c4e665 ENH: consistency improvements for surface patch handling (fixes #483)
- remove (unused) Istream constructors, prune some unused methods,
  rationalize write() vs writeDict().
  Deprecate inconsistent construction order.

- handle empty names for ".ftr" surface patches (for plain triSurface
  format) with double-quoted strings for more reliable streaming.
  Written on a single line.

  This is _backward_ compatible, but if users have been parsing these
  files manually, they will need to adjust their code.

Previously:
```
  (
  frt-fairing:001%1
  empty

  windshield:002%2
  empty
  ...
  )
```

Updated (with example handling of empty name):
```
  (
  frt-fairing:001%1 empty

  windshield:002%2 ""
  ...
  )
```
2020-01-16 10:07:26 +01:00
Mark Olesen
9dbf94777c GIT: relocate geometricSurfacePatch, geometricSurfacePatchList
- was in surfMesh/triSurface/patches/
  now in OpenFOAM/meshes/Identifiers/surface/

This places the code closer to other identifier classes,
which aids in maintaining consistency
2020-01-15 17:21:22 +01:00
Mark Olesen
5979078ede STYLE: avoid copy in fieldSelection 2020-01-13 17:14:45 +01:00
Mark Olesen
b5b55fbd86 STYLE: noexcept specification instead of throw()
- make IOerror constructors explicit
2020-01-09 12:38:53 +01:00
Mark Olesen
669f3de327 TUT: file cleanup 2020-01-17 08:11:05 +01:00
OpenFOAM bot
596e4aef3f STYLE: remove trailing space, tabs 2020-01-22 10:00:03 +01:00
sergio
f172309956 BUG: Fix sigmap for scatter particle radiation 2020-01-21 14:10:22 -08:00
Andrew Heather
00a88f2cab Merge branch 'feature-shm-faceZoneRegions' into 'develop'
ENH: shm: support for automatic faceZones

See merge request Development/openfoam!327
2020-01-16 12:22:02 +00:00
Mattijs Janssens
b8c2c0acf6 ENH: shm: support for automatic faceZones 2020-01-16 12:22:02 +00:00
Mattijs Janssens
0c7140c967 Merge branch 'feature-regIOobject-store' into 'develop'
ENH: regIOobject store() now also registers the object

See merge request Development/openfoam!326
2020-01-13 15:42:53 +00:00
Mark Olesen
b0072bfab8 ENH: regIOobject store() now also registers the object
- previously the store() method just set the ownedByRegistry flag.
  Now ensure that it is indeed registered first.

- support register/store of tmp<> items.
  The tmp parameter is not cleared, but changed from PTR to CREF
  to allow further use.

  The implicit registration allows code simplification using the
  GeometricField::New factory method, for example.

  Old Code
  ========
      volScalarField* ptr = new volScalarField
      (
          IOobject
          (
              fieldName,
              mesh.time().timeName(),
              mesh,
              IOobject::NO_READ,
              IOobject::NO_WRITE,
              true  // Register
          ),
          mesh,
          dimless,
          zeroGradientFvPatchField<scalar>::typeName
      );
      ptr->store();

  New Code
  ========
      auto tptr = volScalarField::New
      (
          fieldName,
          mesh,
          dimless,
          zeroGradientFvPatchField<scalar>::typeName
      );
      regIOobject::store(tptr);

  or even
      regIOobject::store
      (
          volScalarField::New
          (
              fieldName,
              mesh,
              dimless,
              zeroGradientFvPatchField<scalar>::typeName
          )
      );
2020-01-13 15:37:25 +00:00
mattijs
12bd45673a BUG: coded: preserve VERBATIMSTRING. Fixes #1497. 2020-01-13 15:10:07 +00:00
Mark Olesen
9b67ffaf74 COMP: update lemon to 2019-12-19 version 2020-01-13 13:56:23 +01:00
Mark Olesen
8fdb9b2f70 COMP: robuster storage of pv/vtk sentinel files with out-of-source builds 2020-01-13 13:56:23 +01:00
mattijs
b1a866c37c BUG: collated: correctly handle ascii writing. See #1545.
The collated container ('decomposedBlockData') is always binary
but the 'payload' might be ascii so use that header information
instead of the decomposeBlockData header.
2020-01-13 11:23:30 +00:00
Andrew Heather
4e73d0e40e Merge remote-tracking branch 'origin/master' into develop 2020-01-10 10:02:08 +00:00
Andrew Heather
a1fbe8283c Merge branch 'misc-kbc-jan-1' into 'develop'
TUT: misc cleanup in various tutorials

See merge request Development/openfoam!324
2020-01-10 09:54:55 +00:00
Kutalmis Bercin
a68333d695 TUT: simplify basic/overPotentialFoam/cylinder
BAKW: ensures bitwise backward compatibility
2020-01-10 09:44:38 +00:00
Kutalmis Bercin
b81106f837 TUT: enable purgeWrite in driftFluxFoam tuts to avoid numerous write-outs 2020-01-10 09:44:38 +00:00
Kutalmis Bercin
8504c813d0 TUT: remove redundant white-spaces in interFoam/motorBike 2020-01-10 09:44:38 +00:00
Kutalmis Bercin
152890d288 TUT: change residuals FO remnants to solverInfo FO (#1290) 2020-01-10 09:44:38 +00:00
Kutalmis Bercin
bda695d97a TUT: simplify basic/overLaplacianDyMFoam/heatTransfer
BAKW: ensure bitwise backward compatibility
2020-01-10 09:44:33 +00:00
Andrew Heather
eb125303c0 Merge branch 'bug-bound-sensitivities' into 'master'
BUG: wrong bounding of sensitivity contituents in case of many control boxes (Fixes #1549)

Closes #1549

See merge request Development/openfoam!325
2020-01-09 21:04:40 +00:00
Vaggelis Papoutsis
ed63d9b2c6 BUG: wrong bounding of sensitivity contituents in case of many control boxes (Fixes #1549)
When more than one volumetric B-Splines control boxes are present, the
sensitivity constituents corresponding to the non-active design
variables were not bounded(zeroed) correctly. The resultant
sensitivities, used in the optimization, were bounded correctly, so this
was more a bug pertaining to the output file of the sensitivities rather
than a functional one.
2020-01-09 20:26:41 +02:00
Kutalmis Bercin
c399a4b3fb TUT: simplify basic/laplacianFoam/flange
BAKW: ensure bitwise backward compatibility
2020-01-09 17:19:36 +00:00
mattijs
45a0f70a28 ENH: shortestPathSet: snappyHexMesh leak detection. Improved walking. 2020-01-09 11:37:40 +00:00