Commit Graph

22019 Commits

Author SHA1 Message Date
Mark Olesen
e7fde1dbe0 STYLE: use std::initializer_list instead of const char*[] 2019-01-07 12:49:37 +01:00
Mark Olesen
573a313f46 STYLE: deprecate hashedWordList contains() method
- identical to found(), which should be used for more consistency.
  The contains() is a remnant from when hashedWordList was generalized
  from a speciesTable (OCT 2010)
2019-01-07 09:51:45 +01:00
Mark Olesen
86e1933057 ENH: iterator method good() as a synonym for testing validity
- applies to HashTable and Linked-Lists

- deprecate the Linked-List iterator found() method, since this makes
  less sense (linguistically)
2019-01-04 14:07:01 +01:00
Mark Olesen
0dbd05daa4 STYLE: minor adjustment of test case 2019-01-03 19:16:13 +01:00
Mark Olesen
e596377179 STYLE: avoid flush when dictionary {} closing (issue #1145)
- a holdover from introducing the endBlock() method
2019-01-03 19:12:12 +01:00
Mark Olesen
6a448016aa ENH: additional read guards for dimensionedType. input consistency (#762, #1148)
- provide a lookupOrDefault constructor form, since this is a fairly
  commonly used requirement and simplifies the calling sequence.

  Before

      dimensionedScalar rhoMax
      (
          dimensionedScalar::lookupOrDefault
          (
              "rhoMax",
              pimple.dict(),
              dimDensity,
              GREAT
          )
     );

  After

      dimensionedScalar rhoMax("rhoMax", dimDensity, GREAT, pimple.dict());

- read, readIfPresent methods with alternative lookup names.

- Mark the Istream related constructors with compile-time deprecated
  warnings.

BUG: read, readIfPresent methods not handling optional dimensions (#1148)
2019-01-03 13:34:11 +01:00
Mark Olesen
af310075a0 ENH: handle dimensions in dimensioned<Type>::lookupOrAddToDict (#1116) 2019-01-03 01:30:27 +01:00
Mark Olesen
488150cfb2 ENH: add FOAM_DEPRECATED macros 2019-01-03 00:36:30 +01:00
Mark Olesen
505b4b9c1c ENH: add guarded lookup for dimensionedSet
STYLE: use standard dimensionedSets
2019-01-02 16:53:41 +01:00
Mark Olesen
2ce944a748 STYLE: documentation/comment typo 2019-01-02 16:16:45 +01:00
Mark Olesen
e2bc0b55b9 COMP: use std::move() explicitly to avoid copying 2019-01-02 15:56:54 +01:00
Mark Olesen
f67f36c63a COMP: avoid some static analysis warnings 2019-01-02 13:49:39 +01:00
Mark Olesen
7bf25dbda1 ENH: add 'Scan' WM_COMPILE_OPTION (clang only)
- backend settings for scan-build
2019-01-02 11:49:49 +01:00
Mark Olesen
4ecdb2512d CONFIG: add llvm-7.0.1
STYLE: generalize rule for obtaining compiler stem
2019-01-02 11:08:21 +01:00
Mark Olesen
c13199d3ce STYLE: make chemistryReader private inheritance (issue #1144)
- The chemistryReader is only used during construction of reactingMixture
  and thus does not require public visibility.
2019-01-02 14:44:21 +01:00
mattijs
3a374bf315 ENH: polyMesh: do not switch on auto-write. Fixes #1147. 2019-01-07 11:08:58 +00:00
mattijs
c143c3a32c STYLE: columnFvMesh: typo 2019-01-03 14:37:37 +00:00
Mark Olesen
7f9ba23be1 STYLE: stage various foamPack* script as 'legacy' (#914)
- this scripts are largely pre-git era and not used much anymore.
  Relocate to a legacy/ sub-directory while we see if there are
  actually any still being used.
2018-12-21 18:52:17 +01:00
Mark Olesen
855faae858 STYLE: surfaceMeshTriangulate renamed to surfaceMeshExtract
- the utility had automatic triangulation removed some time ago, but
  never changed its name.

- catch old uses with a surfaceMeshTriangulate deprecated script
2018-12-21 18:37:39 +01:00
Mark Olesen
2c70dfc51d ENH: add pdf option to foamCreateManpage 2018-12-21 16:06:19 +01:00
Mark Olesen
603dd28fc8 GIT: update submodule refs after tagging and re-merging 2018-12-21 16:04:17 +01:00
Mark Olesen
3560884abe ENH: allow direct testing of HashTable iterator as a bool
- can be used as a more natural test on the iterator.
  For example, with

     HashTable<..> table;
     auto iter = table.find(...);

  Following are now all equivalent:

    1.  if (iter != table.end()) ...
    2.  if (iter.found()) ...
    3.  if (iter) ...
2018-12-20 18:03:16 +01:00
Mark Olesen
08335beb6f ENH: add get() accessor to tmp classes
- similar to autoPtr and unique_ptr. Returns the pointer value without
  any checks. This provides a simple way for use to use either
  an autoPtr or a tmp for local memory management without accidentally
  stealing the pointer.

  Eg,

     volVectorField* ptr;
     tmp<volVectorField> tempField;

     if (someField.valid())
     {
         ptr = someField.get();
     }
     else
     {
         tempField.reset(new volVectorField(....));
         ptr = tmpField.get();
     }

     const volVectorField& withField = *ptr;

STYLE: make more tmp methods noexcept
2018-12-20 17:29:51 +01:00
Mark Olesen
17419209a7 STYLE: return a pointer instead of bool for isA<>
- in some cases this means you could avoid an isA<> followed by
  second dynamicCast<>
2018-12-20 18:02:16 +01:00
Mark Olesen
1d85fecf4d ENH: use Zero when zero-initializing types
- makes the intent clearer and avoids the need for additional
  constructor casting. Eg,

      labelList(10, Zero)    vs.  labelList(10, 0)
      scalarField(10, Zero)  vs.  scalarField(10, scalar(0))
      vectorField(10, Zero)  vs.  vectorField(10, vector::zero)
2018-12-11 23:50:15 +01:00
Mark Olesen
6e8cf684d1 STYLE: reduce else/if levels for return 2018-12-21 09:38:16 +01:00
Mark Olesen
a9f5f181c6 STYLE: remove extra '(' in usage information, doubled ';;' 2018-12-21 09:22:06 +01:00
Mark Olesen
a403e72277 TUT: tidying of periodicHill 2018-12-20 10:26:18 +01:00
Andrew Heather
2a51537d78 STYLE: reset WM_PROJECT_VERSION for the develop branch 2018-12-20 18:06:41 +00:00
Andrew Heather
2444e0f964 Merge branch 'release-v1812' 2018-12-20 16:12:59 +00:00
Andrew Heather
9231534efa STYLE: Updating version to v1812 2018-12-19 18:07:52 +00:00
Andrew Heather
756e00ac56 GIT: Removed file 2018-12-20 16:10:42 +00:00
Andrew Heather
7882f952f3 TUT: Added missing files 2018-12-20 15:15:30 +00:00
mattijs
df58bb96a8 BUG: swirlFanVelocity: preserve pressure name. Fixes #1138. 2018-12-20 14:33:49 +00:00
mattijs
e22606756b BUG: meanVelictyForce: missing correctBoundaryConditions. Fixes #1136. 2018-12-20 09:23:10 +00:00
Andrew Heather
c03c6bdea2 TUT: Corrections 2018-12-20 09:05:02 +00:00
mattijs
9f97084605 STYLE: fvSolution: include unused file 2018-12-19 16:31:13 +00:00
mattijs
b476b56afb BUG: meanVelictyForce: missing correctBoundaryConditions 2018-12-19 16:29:10 +00:00
mattijs
4910dbc995 STYLE: particle: improved warning message 2018-12-19 11:31:44 +00:00
Mark Olesen
7ee1ec92ec STYLE: add usage information for subsetMesh argument 2018-12-19 15:15:28 +01:00
Mark Olesen
e8f25b1385 BUG: foamToVTK, vtkWrite stopped by processorCyclic (closes #1135)
- they had an isType<> instead of isA<>() check
2018-12-19 13:56:20 +01:00
mattijs
cb152896b0 BUG: snappyHexMeshDict: illegal slip patch type 2018-12-19 09:56:33 +00:00
Andrew Heather
97fc516563 ENH: Added new periodicHill test case 2018-12-19 09:46:26 +00:00
Andrew Heather
79f9c3bb7d TUT: Added new bump2D case 2018-12-18 19:08:03 +00:00
Andrew Heather
485523eab5 ENH: Added new columnAverage function object
Averages columns of cells for layered meshes.

    For each patch face, calculates the average value of all cells attached in
    the patch face normal direction, and then pushes the average value back
    to all cells in the column.

    Useful for channel-like cases where we want to average fields in the
    spanwise direction.

    Example of function object specification:
    columnAverage1
    {
        type        columnAverage;
        libs        ("libfieldFunctionObjects.so");
        ...
        patches     (front side);
        fields      (U p);
    }

    Where the entries comprise:
    \table
        Property     | Description               | Required    | Default value
        type         | type name: fieldMinMax    | yes         |
        patches      | list of patches to collapse onto | yes  |
        fields       | list of fields to process | yes         |
    \endtable
2018-12-18 10:35:34 +00:00
Andrew Heather
e145034a6d STYLE: Code clean-up 2018-12-17 12:02:55 +00:00
Mark Olesen
4c14bc66ef STYLE: foamVersion alias should not change directory (closes #1131) 2018-12-19 07:54:35 +01:00
Mark Olesen
b0eeea8365 STYLE: fix doc for patchTo.. topo sources 2018-12-18 16:28:27 +01:00
Mark Olesen
7ee9c3b8c0 TUT: add vtkWrite to movingCone 2018-12-17 18:16:40 +01:00
sergio
a85fb097ef ENH: Allowing negative pressure drop in fan BC (EP 815) 2018-12-17 08:34:10 -08:00